RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 16:37:47 +00:00
Code Issues Activity Actions

Games: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-16 11:44:57 -07:00 • committed by Linus Groh
parent 9521f71944
commit 27c30ca063
26 changed files with 41 additions and 82 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Games/Minesweeper/CustomGameDialog.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Pedro Pereira <pmh.pereira@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -74,7 +75,3 @@ CustomGameDialog::CustomGameDialog(Window* parent_window)
set_max_mines();
}
CustomGameDialog::~CustomGameDialog()
{
}

3
Userland/Games/Minesweeper/CustomGameDialog.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Pedro Pereira <pmh.pereira@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -20,7 +21,7 @@ public:
private:
CustomGameDialog(GUI::Window* parent_window);
virtual ~CustomGameDialog() override;
virtual ~CustomGameDialog() override = default;
void set_max_mines();

13
Userland/Games/Minesweeper/Field.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -155,10 +156,6 @@ Field::Field(GUI::Label& flag_label, GUI::Label& time_label, GUI::Button& face_b
}
}
Field::~Field()
{
}
void Field::set_face(Face face)
{
switch (face) {
@ -530,14 +527,6 @@ void Field::set_single_chording(bool enabled)
Config::write_bool("Minesweeper", "Game", "SingleChording", m_single_chording);
}
Square::Square()
{
}
Square::~Square()
{
}
template<typename Callback>
void Field::for_each_square(Callback callback)
{

7
Userland/Games/Minesweeper/Field.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -19,8 +20,8 @@ class Square {
AK_MAKE_NONCOPYABLE(Square);
public:
Square();
~Square();
Square() = default;
~Square() = default;
Field* field { nullptr };
bool is_swept { false };
@ -43,7 +44,7 @@ class Field final : public GUI::Frame {
friend class SquareLabel;
public:
virtual ~Field() override;
virtual ~Field() override = default;
enum class Difficulty {
Beginner,