From 286ea068fc0aeef5e9aa93c2c16c1e9deb2ba10e Mon Sep 17 00:00:00 2001 From: Aliaksandr Kalenik Date: Mon, 11 Dec 2023 12:54:32 +0100 Subject: [PATCH] LibWeb: Use JS::Handle for page pointer in LoadRequest Since we can't visit page pointer from LoadRequest we need to use JS::Handle to keep it alive. --- Userland/Libraries/LibWeb/Loader/LoadRequest.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibWeb/Loader/LoadRequest.h b/Userland/Libraries/LibWeb/Loader/LoadRequest.h index 34a91e4e24..39bf83cd82 100644 --- a/Userland/Libraries/LibWeb/Loader/LoadRequest.h +++ b/Userland/Libraries/LibWeb/Loader/LoadRequest.h @@ -43,7 +43,7 @@ public: void start_timer() { m_load_timer.start(); } Duration load_time() const { return m_load_timer.elapsed_time(); } - JS::GCPtr page() { return m_page; } + JS::GCPtr page() { return m_page.ptr(); } void set_page(Page& page) { m_page = page; } unsigned hash() const @@ -79,7 +79,7 @@ private: HashMap m_headers; ByteBuffer m_body; Core::ElapsedTimer m_load_timer; - JS::GCPtr m_page; + JS::Handle m_page; bool m_main_resource { false }; };