mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 01:07:36 +00:00
AK: Fix bad parsing of some file:/// URLs with base URL
We were dropping the base URL path components in the resulting URL due to mistakenly determining the input URL to start with a Windows drive letter. Fix this, add a spec link, and a test.
This commit is contained in:
parent
ac76df3d47
commit
287a9b552a
2 changed files with 16 additions and 1 deletions
|
@ -84,11 +84,12 @@ static Optional<String> parse_host(StringView input, bool is_not_special = false
|
|||
return ipv4_host;
|
||||
}
|
||||
|
||||
// https://url.spec.whatwg.org/#start-with-a-windows-drive-letter
|
||||
constexpr bool starts_with_windows_drive_letter(StringView input)
|
||||
{
|
||||
if (input.length() < 2)
|
||||
return false;
|
||||
if (!is_ascii_alpha(input[0]) && !(input[1] == ':' || input[1] == '|'))
|
||||
if (!is_ascii_alpha(input[0]) || !(input[1] == ':' || input[1] == '|'))
|
||||
return false;
|
||||
if (input.length() == 2)
|
||||
return true;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue