RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 15:27:35 +00:00
Code Issues Activity Actions

LoginServer: Change login fail message to avoid enumeration attacks

Browse source 
The current message distinguishes between a user that doesn't exist, and
an invalid password. This is considered to be bad practice, because an
attack can first check if a user exists before guessing that users
password.

Also it's just tradition or something.
This commit is contained in:
Peter Elliott 2022-04-26 19:58:54 -06:00 • committed by Brian Gianforcaro
parent 19f6ef3a0c
commit 287c6228b5
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Services/LoginServer/LoginWindow.gml
View file

@ -30,8 +30,6 @@
text_alignment: "CenterLeft" text_alignment: "CenterLeft"
} }
@GUI::Widget {}
@GUI::Button { @GUI::Button {
name: "log_in" name: "log_in"
text: "Log in" text: "Log in"

6
Userland/Services/LoginServer/main.cpp
View file

@ -72,15 +72,17 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
window->set_password(""); window->set_password("");
auto fail_message = "Can't log in: invalid username or password.";
auto account = Core::Account::from_name(username.characters()); auto account = Core::Account::from_name(username.characters());
if (account.is_error()) { if (account.is_error()) {
window->set_fail_message(String::formatted("Can't log in: {}.", account.error())); window->set_fail_message(fail_message);
dbgln("failed graphical login for user {}: {}", username, account.error()); dbgln("failed graphical login for user {}: {}", username, account.error());
return; return;
} }
if (!account.value().authenticate(password)) { if (!account.value().authenticate(password)) {
window->set_fail_message("Can't log in: invalid password."); window->set_fail_message(fail_message);
dbgln("failed graphical login for user {}: invalid password", username); dbgln("failed graphical login for user {}: invalid password", username);
return; return;
} }