RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 10:37:41 +00:00
Code Issues Activity Actions

LibWeb: Make ImageRequest store Page member as NonnullGCPtr

Browse source 
Co-Authored-By: Andreas Kling <kling@serenityos.org>
This commit is contained in:
Shannon Booth 2023-12-03 15:29:11 +13:00 • committed by Andreas Kling
parent d277ac72e6
commit 289ea2db9c
2 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/ImageRequest.cpp
View file

@ -14,6 +14,7 @@
#include <LibWeb/HTML/DecodedImageData.h> #include <LibWeb/HTML/DecodedImageData.h>
#include <LibWeb/HTML/ImageRequest.h> #include <LibWeb/HTML/ImageRequest.h>
#include <LibWeb/HTML/ListOfAvailableImages.h> #include <LibWeb/HTML/ListOfAvailableImages.h>
#include <LibWeb/Page/Page.h>
#include <LibWeb/Platform/ImageCodecPlugin.h> #include <LibWeb/Platform/ImageCodecPlugin.h>
#include <LibWeb/SVG/SVGDecodedImageData.h> #include <LibWeb/SVG/SVGDecodedImageData.h>
@ -21,12 +22,12 @@ namespace Web::HTML {
JS_DEFINE_ALLOCATOR(ImageRequest); JS_DEFINE_ALLOCATOR(ImageRequest);
JS::NonnullGCPtr<ImageRequest> ImageRequest::create(JS::Realm& realm, Page& page) JS::NonnullGCPtr<ImageRequest> ImageRequest::create(JS::Realm& realm, JS::NonnullGCPtr<Page> page)
{ {
return realm.heap().allocate<ImageRequest>(realm, page); return realm.heap().allocate<ImageRequest>(realm, page);
} }
ImageRequest::ImageRequest(Page& page) ImageRequest::ImageRequest(JS::NonnullGCPtr<Page> page)
: m_page(page) : m_page(page)
{ {
} }
@ -39,6 +40,7 @@ void ImageRequest::visit_edges(JS::Cell::Visitor& visitor)
{ {
Base::visit_edges(visitor); Base::visit_edges(visitor);
visitor.visit(m_shared_image_request); visitor.visit(m_shared_image_request);
visitor.visit(m_page);
} }
// https://html.spec.whatwg.org/multipage/images.html#img-available // https://html.spec.whatwg.org/multipage/images.html#img-available

6
Userland/Libraries/LibWeb/HTML/ImageRequest.h
View file

@ -22,7 +22,7 @@ class ImageRequest final : public JS::Cell {
JS_DECLARE_ALLOCATOR(ImageRequest); JS_DECLARE_ALLOCATOR(ImageRequest);
public: public:
[[nodiscard]] static JS::NonnullGCPtr<ImageRequest> create(JS::Realm&, Page&); [[nodiscard]] static JS::NonnullGCPtr<ImageRequest> create(JS::Realm&, JS::NonnullGCPtr<Page>);
~ImageRequest(); ~ImageRequest();
@ -63,9 +63,9 @@ public:
virtual void visit_edges(JS::Cell::Visitor&) override; virtual void visit_edges(JS::Cell::Visitor&) override;
private: private:
explicit ImageRequest(Page&); explicit ImageRequest(JS::NonnullGCPtr<Page>);
Page& m_page; JS::NonnullGCPtr<Page> m_page;
// https://html.spec.whatwg.org/multipage/images.html#img-req-state // https://html.spec.whatwg.org/multipage/images.html#img-req-state
// An image request's state is initially unavailable. // An image request's state is initially unavailable.