From 28ac5a1333dfad3173b83b0f79f34c8a67624963 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Fri, 4 Feb 2022 19:17:06 +0000 Subject: [PATCH] LibJS: Update fallibility of ParseISODateTime in spec comments This is an editorial change in the Temporal spec. See: https://github.com/tc39/proposal-temporal/commit/bc79069 --- .../LibJS/Runtime/Temporal/AbstractOperations.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp index 7ce7e96fd1..9c1efab97f 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp +++ b/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp @@ -1241,8 +1241,7 @@ ThrowCompletionOr parse_temporal_instant_string(GlobalObject& g return vm.throw_completion(global_object, ErrorType::TemporalInvalidInstantString, iso_string); } - // 3. Let result be ! ParseISODateTime(isoString). - // NOTE: !/? confusion is a spec issue. See: https://github.com/tc39/proposal-temporal/pull/2027 + // 3. Let result be ? ParseISODateTime(isoString). auto result = TRY(parse_iso_date_time(global_object, *parse_result)); // 4. Let timeZoneResult be ? ParseTemporalTimeZoneString(isoString). @@ -1278,8 +1277,7 @@ ThrowCompletionOr parse_temporal_zoned_date_time_string(G return vm.throw_completion(global_object, ErrorType::TemporalInvalidZonedDateTimeString, iso_string); } - // 3. Let result be ! ParseISODateTime(isoString). - // NOTE: !/? confusion is a spec issue. See: https://github.com/tc39/proposal-temporal/pull/2027 + // 3. Let result be ? ParseISODateTime(isoString). auto result = TRY(parse_iso_date_time(global_object, *parse_result)); // 4. Let timeZoneResult be ? ParseTemporalTimeZoneString(isoString). @@ -1561,8 +1559,7 @@ ThrowCompletionOr parse_temporal_relative_to_string(Globa return vm.throw_completion(global_object, ErrorType::TemporalInvalidRelativeToString, iso_string); } - // 3. Let result be ! ParseISODateTime(isoString). - // NOTE: !/? confusion is a spec issue. See: https://github.com/tc39/proposal-temporal/pull/2027 + // 3. Let result be ? ParseISODateTime(isoString). auto result = TRY(parse_iso_date_time(global_object, *parse_result)); bool z;