RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-10 06:07:35 +00:00
Code Issues Activity Actions

Kernel: Minor cleanups in sendfd/recvfd

Browse source 
Applying some nice suggestions by @bugaevc. :^)
This commit is contained in:
Andreas Kling 2020-06-25 10:51:30 +02:00
parent d1d01897a3
commit 28bfd73b68
2 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Kernel/Net/LocalSocket.cpp
View file

@ -397,7 +397,7 @@ KResult LocalSocket::chown(FileDescription&, uid_t uid, gid_t gid)
return KSuccess; return KSuccess;
} }
NonnullRefPtrVector<FileDescription>& LocalSocket::recvfd_queue_for(FileDescription& description) NonnullRefPtrVector<FileDescription>& LocalSocket::recvfd_queue_for(const FileDescription& description)
{ {
auto role = this->role(description); auto role = this->role(description);
if (role == Role::Connected) if (role == Role::Connected)
@ -407,7 +407,7 @@ NonnullRefPtrVector<FileDescription>& LocalSocket::recvfd_queue_for(FileDescript
ASSERT_NOT_REACHED(); ASSERT_NOT_REACHED();
} }
NonnullRefPtrVector<FileDescription>& LocalSocket::sendfd_queue_for(FileDescription& description) NonnullRefPtrVector<FileDescription>& LocalSocket::sendfd_queue_for(const FileDescription& description)
{ {
auto role = this->role(description); auto role = this->role(description);
if (role == Role::Connected) if (role == Role::Connected)
@ -417,7 +417,7 @@ NonnullRefPtrVector<FileDescription>& LocalSocket::sendfd_queue_for(FileDescript
ASSERT_NOT_REACHED(); ASSERT_NOT_REACHED();
} }
KResult LocalSocket::sendfd(FileDescription& socket_description, NonnullRefPtr<FileDescription> passing_description) KResult LocalSocket::sendfd(const FileDescription& socket_description, FileDescription& passing_description)
{ {
LOCKER(lock()); LOCKER(lock());
auto role = this->role(socket_description); auto role = this->role(socket_description);
@ -431,7 +431,7 @@ KResult LocalSocket::sendfd(FileDescription& socket_description, NonnullRefPtr<F
return KSuccess; return KSuccess;
} }
KResultOr<NonnullRefPtr<FileDescription>> LocalSocket::recvfd(FileDescription& socket_description) KResultOr<NonnullRefPtr<FileDescription>> LocalSocket::recvfd(const FileDescription& socket_description)
{ {
LOCKER(lock()); LOCKER(lock());
auto role = this->role(socket_description); auto role = this->role(socket_description);

8
Kernel/Net/LocalSocket.h
View file

@ -42,8 +42,8 @@ public:
static KResultOr<NonnullRefPtr<Socket>> create(int type); static KResultOr<NonnullRefPtr<Socket>> create(int type);
virtual ~LocalSocket() override; virtual ~LocalSocket() override;
KResult sendfd(FileDescription& socket_description, NonnullRefPtr<FileDescription> passing_description); KResult sendfd(const FileDescription& socket_description, FileDescription& passing_description);
KResultOr<NonnullRefPtr<FileDescription>> recvfd(FileDescription& socket_description); KResultOr<NonnullRefPtr<FileDescription>> recvfd(const FileDescription& socket_description);
static void for_each(Function<void(const LocalSocket&)>); static void for_each(Function<void(const LocalSocket&)>);
@ -74,8 +74,8 @@ private:
static Lockable<InlineLinkedList<LocalSocket>>& all_sockets(); static Lockable<InlineLinkedList<LocalSocket>>& all_sockets();
DoubleBuffer& receive_buffer_for(FileDescription&); DoubleBuffer& receive_buffer_for(FileDescription&);
DoubleBuffer& send_buffer_for(FileDescription&); DoubleBuffer& send_buffer_for(FileDescription&);
NonnullRefPtrVector<FileDescription>& sendfd_queue_for(FileDescription&); NonnullRefPtrVector<FileDescription>& sendfd_queue_for(const FileDescription&);
NonnullRefPtrVector<FileDescription>& recvfd_queue_for(FileDescription&); NonnullRefPtrVector<FileDescription>& recvfd_queue_for(const FileDescription&);
// An open socket file on the filesystem. // An open socket file on the filesystem.
RefPtr<FileDescription> m_file; RefPtr<FileDescription> m_file;