RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:47:35 +00:00
Code Issues Activity Actions

PixelPaint: Editing mask optimization

Browse source 
This patch introduces a new function "Layer::editin_mask_bounding_rect"
that is used within the LevelsDialog, Luminosity and Colormasking to
process only the area where a mask was applied. Therefore we can
greatly reduce the amount of processed pixels if only a small portion
of the image was masked.
This commit is contained in:
Torstennator 2023-08-21 11:15:49 +02:00 • committed by Sam Atkins
parent b3a6ccc45b
commit 28cda85f1f
6 changed files with 55 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Applications/PixelPaint/LevelsDialog.cpp
View file

@ -89,9 +89,10 @@ void LevelsDialog::generate_new_image()
Color new_pixel_color;
Gfx::StorageFormat storage_format = Gfx::determine_storage_format(m_editor->active_layer()->content_bitmap().format());
auto apply_only_on_mask = m_editor->active_layer()->mask_type() == Layer::MaskType::EditingMask;
auto relevant_area = m_masked_area.value_or({ 0, 0, m_reference_bitmap->width(), m_reference_bitmap->height() });
for (int x = 0; x < m_reference_bitmap->width(); x++) {
for (int y = 0; y < m_reference_bitmap->height(); y++) {
for (int y = relevant_area.top(); y < relevant_area.bottom(); y++) {
for (int x = relevant_area.left(); x < relevant_area.right(); x++) {
current_pixel_color = m_reference_bitmap->get_pixel(x, y);
// Check if we can avoid setting pixels as nothing will change when we don't have a mask at x,y.
@ -123,8 +124,10 @@ void LevelsDialog::generate_new_image()
ErrorOr<void> LevelsDialog::ensure_reference_bitmap()
{
if (m_reference_bitmap.is_null())
if (m_reference_bitmap.is_null()) {
m_reference_bitmap = TRY(m_editor->active_layer()->content_bitmap().clone());
m_masked_area = m_editor->active_layer()->editing_mask_bounding_rect();
}
return {};
}