From 28f1486627f554cef4026af63dcbce1b9bdae30b Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 22 Feb 2020 16:38:49 +0100 Subject: [PATCH] LibCore: Log a more helpful message when Socket::connect() fails Fixes #1272. --- Libraries/LibCore/Socket.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Libraries/LibCore/Socket.cpp b/Libraries/LibCore/Socket.cpp index 35590d541a..11446da741 100644 --- a/Libraries/LibCore/Socket.cpp +++ b/Libraries/LibCore/Socket.cpp @@ -113,6 +113,8 @@ bool Socket::connect(const SocketAddress& address) saddr.sun_family = AF_LOCAL; strcpy(saddr.sun_path, address.to_string().characters()); + m_destination_address = address; + return common_connect((const sockaddr*)&saddr, sizeof(saddr)); } @@ -137,7 +139,9 @@ bool Socket::common_connect(const struct sockaddr* addr, socklen_t addrlen) }; return true; } - perror("Socket::common_connect: connect"); + int saved_errno = errno; + fprintf(stderr, "Core::Socket: Failed to connect() to %s: %s\n", destination_address().to_string().characters(), strerror(saved_errno)); + errno = saved_errno; return false; } #ifdef CSOCKET_DEBUG