mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 04:37:34 +00:00
LibWeb: Detach stale layout nodes from DOM during layout tree build
When toggling `display: none` on an element, it can go from having a layout subtree to not having one. In the `none` case, we were previously leaving stale layout nodes hanging off DOM nodes in the subtree. These layout nodes could be queried for outdated information and probably other things that we shouldn't allow. Fix this by having TreeBuilder prune any old layout nodes hanging off nodes in a subtree after its subtree root doesn't produce a layout node.
This commit is contained in:
parent
0805060e5e
commit
28fdc7af05
5 changed files with 33 additions and 3 deletions
|
@ -882,7 +882,7 @@ void Node::set_layout_node(Badge<Layout::Node>, JS::NonnullGCPtr<Layout::Node> l
|
|||
m_layout_node = layout_node;
|
||||
}
|
||||
|
||||
void Node::detach_layout_node(Badge<DOM::Document>)
|
||||
void Node::detach_layout_node(Badge<Layout::TreeBuilder>)
|
||||
{
|
||||
m_layout_node = nullptr;
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue