From 29261809ef097d532411589888ae408703a52db0 Mon Sep 17 00:00:00 2001 From: Ben Wiederhake Date: Sun, 11 Sep 2022 21:28:42 +0200 Subject: [PATCH] LibCrypto+Tests: Test and demonstrate broken ASN1::parse_utc_time --- Tests/LibCrypto/CMakeLists.txt | 1 + Tests/LibCrypto/TestASN1.cpp | 66 ++++++++++++++++++++++++++++++++++ 2 files changed, 67 insertions(+) create mode 100644 Tests/LibCrypto/TestASN1.cpp diff --git a/Tests/LibCrypto/CMakeLists.txt b/Tests/LibCrypto/CMakeLists.txt index 81e3176ba2..c1c56c2e86 100644 --- a/Tests/LibCrypto/CMakeLists.txt +++ b/Tests/LibCrypto/CMakeLists.txt @@ -1,5 +1,6 @@ set(TEST_SOURCES TestAES.cpp + TestASN1.cpp TestBigInteger.cpp TestChecksum.cpp TestChaCha20.cpp diff --git a/Tests/LibCrypto/TestASN1.cpp b/Tests/LibCrypto/TestASN1.cpp new file mode 100644 index 0000000000..6c766b787e --- /dev/null +++ b/Tests/LibCrypto/TestASN1.cpp @@ -0,0 +1,66 @@ +/* + * Copyright (c) 2022, Ben Wiederhake + * + * SPDX-License-Identifier: BSD-2-Clause + */ + +#include +#include +#include + +#define EXPECT_DATETIME(sv, y, mo, d, h, mi, s) \ + EXPECT_EQ(Crypto::ASN1::parse_utc_time(sv).value(), Core::DateTime::create(y, mo, d, h, mi, s)) + +TEST_CASE(test_utc_boring) +{ + // YYMMDDhhmm[ss]Z + EXPECT_DATETIME("010101010101Z"sv, 2001, 1, 1, 1, 1, 1); + EXPECT_DATETIME("010203040506Z"sv, 2001, 2, 3, 4, 5, 6); + EXPECT_DATETIME("020406081012Z"sv, 2002, 4, 6, 8, 10, 12); + EXPECT_DATETIME("0204060810Z"sv, 2002, 4, 6, 8, 10, 0); + EXPECT_DATETIME("220911220000Z"sv, 2022, 9, 11, 22, 0, 0); +} + +TEST_CASE(test_utc_year_rollover) +{ + // YYMMDDhhmm[ss]Z + EXPECT_DATETIME("000101010101Z"sv, 2000, 1, 1, 1, 1, 1); + EXPECT_DATETIME("010101010101Z"sv, 2001, 1, 1, 1, 1, 1); + EXPECT_DATETIME("020101010101Z"sv, 2002, 1, 1, 1, 1, 1); + // ... + EXPECT_DATETIME("480101010101Z"sv, 2048, 1, 1, 1, 1, 1); + EXPECT_DATETIME("490101010101Z"sv, 2049, 1, 1, 1, 1, 1); + // This Y2050-problem is hardcoded in the spec. Oh no. + EXPECT_DATETIME("500101010101Z"sv, 1950, 1, 1, 1, 1, 1); + EXPECT_DATETIME("510101010101Z"sv, 1951, 1, 1, 1, 1, 1); + // ... + EXPECT_DATETIME("970101010101Z"sv, 1997, 1, 1, 1, 1, 1); + EXPECT_DATETIME("980101010101Z"sv, 1998, 1, 1, 1, 1, 1); + EXPECT_DATETIME("990101010101Z"sv, 1999, 1, 1, 1, 1, 1); +} + +TEST_CASE(test_utc_offset) +{ + // YYMMDDhhmm[ss](+|-)hhmm + // We don't yet support storing the offset anywhere and instead just assume that the offset is just +0000. + EXPECT_DATETIME("010101010101+0000"sv, 2001, 1, 1, 1, 1, 1); + EXPECT_DATETIME("010203040506+0000"sv, 2001, 2, 3, 4, 5, 6); + EXPECT_DATETIME("020406081012+0000"sv, 2002, 4, 6, 8, 10, 12); + EXPECT_DATETIME("0204060810+0000"sv, 2002, 4, 6, 8, 10, 0); + EXPECT_DATETIME("220911220000+0000"sv, 2022, 9, 11, 22, 0, 0); + // Designed to fail once we support offsets: + EXPECT_DATETIME("220911220000+0600"sv, 2022, 9, 11, 22, 0, 0); +} + +TEST_CASE(test_utc_missing_z) +{ + // YYMMDDhhmm[ss] + // We don't actually need to parse this correctly; rejecting these inputs is fine. + // This test just makes sure that we don't crash. + // FIXME: This currently crashes + // (void)Crypto::ASN1::parse_utc_time("010101010101"sv); + // (void)Crypto::ASN1::parse_utc_time("010203040506"sv); + // (void)Crypto::ASN1::parse_utc_time("020406081012"sv); + // (void)Crypto::ASN1::parse_utc_time("0204060810"sv); + // (void)Crypto::ASN1::parse_utc_time("220911220000"sv); +}