RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 01:47:35 +00:00
Code Issues Activity Actions

LibWeb: Support list-style-position

Browse source 
This moves the ::marker inside of <summary> actually inside. :^)
This commit is contained in:
Simon Wanner 2023-06-02 23:05:15 +02:00 • committed by Andreas Kling
parent ee7282cbe4
commit 293ece2292
10 changed files with 34 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/CSS/ComputedValues.h
View file

@ -46,6 +46,7 @@ public:
static CSS::BackdropFilter backdrop_filter() { return BackdropFilter::make_none(); }
static Color background_color() { return Color::Transparent; }
static CSS::ListStyleType list_style_type() { return CSS::ListStyleType::Disc; }
static CSS::ListStylePosition list_style_position() { return CSS::ListStylePosition::Outside; }
static CSS::Visibility visibility() { return CSS::Visibility::Visible; }
static CSS::FlexDirection flex_direction() { return CSS::FlexDirection::Row; }
static CSS::FlexWrap flex_wrap() { return CSS::FlexWrap::Nowrap; }
@ -288,6 +289,7 @@ public:
Vector<BackgroundLayerData> const& background_layers() const { return m_noninherited.background_layers; }
CSS::ListStyleType list_style_type() const { return m_inherited.list_style_type; }
CSS::ListStylePosition list_style_position() const { return m_inherited.list_style_position; }
Optional<SVGPaint> const& fill() const { return m_inherited.fill; }
Optional<SVGPaint> const& stroke() const { return m_inherited.stroke; }
@ -327,6 +329,7 @@ protected:
CSS::LengthPercentage text_indent { InitialValues::text_indent() };
CSS::WhiteSpace white_space { InitialValues::white_space() };
CSS::ListStyleType list_style_type { InitialValues::list_style_type() };
CSS::ListStylePosition list_style_position { InitialValues::list_style_position() };
CSS::Visibility visibility { InitialValues::visibility() };
Optional<SVGPaint> fill;
@ -448,6 +451,7 @@ public:
void set_overflow_x(CSS::Overflow value) { m_noninherited.overflow_x = value; }
void set_overflow_y(CSS::Overflow value) { m_noninherited.overflow_y = value; }
void set_list_style_type(CSS::ListStyleType value) { m_inherited.list_style_type = value; }
void set_list_style_position(CSS::ListStylePosition value) { m_inherited.list_style_position = value; }
void set_display(CSS::Display value) { m_noninherited.display = value; }
void set_backdrop_filter(CSS::BackdropFilter backdrop_filter) { m_noninherited.backdrop_filter = move(backdrop_filter); }
void set_border_bottom_left_radius(CSS::BorderRadiusData value) { m_noninherited.border_bottom_left_radius = move(value); }

4
Userland/Libraries/LibWeb/CSS/Enums.json
View file

@ -190,6 +190,10 @@
"upper-latin",
"upper-roman"
],
"list-style-position": [
"inside",
"outside"
],
"overflow": [
"auto",
"clip",

5
Userland/Libraries/LibWeb/CSS/Properties.json
View file

@ -1232,9 +1232,8 @@
"list-style-position": {
"inherited": true,
"initial": "outside",
"valid-identifiers": [
"inside",
"outside"
"valid-types": [
"list-style-position"
]
},
"list-style-type": {

6
Userland/Libraries/LibWeb/CSS/StyleProperties.cpp
View file

@ -711,6 +711,12 @@ Optional<CSS::ListStyleType> StyleProperties::list_style_type() const
return value_id_to_list_style_type(value->to_identifier());
}
Optional<CSS::ListStylePosition> StyleProperties::list_style_position() const
{
auto value = property(CSS::PropertyID::ListStylePosition);
return value_id_to_list_style_position(value->to_identifier());
}
Optional<CSS::Overflow> StyleProperties::overflow_x() const
{
return overflow(CSS::PropertyID::OverflowX);

1
Userland/Libraries/LibWeb/CSS/StyleProperties.h
View file

@ -63,6 +63,7 @@ public:
Optional<CSS::TextTransform> text_transform() const;
Vector<CSS::ShadowData> text_shadow() const;
Optional<CSS::ListStyleType> list_style_type() const;
Optional<CSS::ListStylePosition> list_style_position() const;
Optional<CSS::FlexDirection> flex_direction() const;
Optional<CSS::FlexWrap> flex_wrap() const;
Optional<CSS::FlexBasisData> flex_basis() const;