RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 03:47:35 +00:00
Code Issues Activity Actions

Profiler: Don't try to create a DisassemblyModel for invalid indices

Browse source 
This fixes a null dereference when toggling the "top functions" mode
while a top-level process node was selected.
This commit is contained in:
Andreas Kling 2021-05-27 11:43:06 +02:00
parent 2ec302ea22
commit 2952c86f38
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/DevTools/Profiler/Profile.cpp
View file

@ -465,7 +465,10 @@ void Profile::set_disassembly_index(const GUI::ModelIndex& index)
return; return;
m_disassembly_index = index; m_disassembly_index = index;
auto* node = static_cast<ProfileNode*>(index.internal_data()); auto* node = static_cast<ProfileNode*>(index.internal_data());
m_disassembly_model = DisassemblyModel::create(*this, *node); if (!node)
m_disassembly_model = nullptr;
else
m_disassembly_model = DisassemblyModel::create(*this, *node);
} }
GUI::Model* Profile::disassembly_model() GUI::Model* Profile::disassembly_model()