RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:47:45 +00:00
Code Issues Activity Actions

LibCore: Add a Socket::set_idle() API that turns the notifiers on/off

Browse source 
When a socket's user doesn't need it to be active, but wants to keep it
open, the socket's notifiers should not be enabled to avoid hogging the
CPU with effectively useless notifications.
This API can be used to disable said notifiers until the user needs the
notifications.
This commit is contained in:
Ali Mohammad Pur 2021-10-04 15:12:33 +03:30 • committed by Andreas Kling
parent 830b0e8f2d
commit 29acb7fcf8
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibCore/Socket.cpp
View file

@ -218,6 +218,14 @@ bool Socket::close()
return IODevice::close();
}
void Socket::set_idle(bool idle)
{
if (m_read_notifier)
m_read_notifier->set_enabled(!idle);
if (m_notifier)
m_notifier->set_enabled(!idle);
}
void Socket::ensure_read_notifier()
{
VERIFY(m_connected);

1
Userland/Libraries/LibCore/Socket.h
View file

@ -43,6 +43,7 @@ public:
int destination_port() const { return m_destination_port; }
virtual bool close() override;
virtual void set_idle(bool);
Function<void()> on_connected;
Function<void()> on_error;