RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:57:45 +00:00
Code Issues Activity Actions

LibChess: Convert Commands to use String and propagate errors

Browse source
This commit is contained in:
Sam Atkins 2023-04-21 15:17:33 +01:00 • committed by Andreas Kling
parent 6576bbc098
commit 29c41e953b
4 changed files with 101 additions and 98 deletions
Download patch file Download diff file Expand all files Collapse all files

138
Userland/Libraries/LibChess/UCICommand.cpp
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2020, the SerenityOS developers. * Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2023, Sam Atkins <atkinssj@serenityos.org>
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -17,9 +18,9 @@ ErrorOr<NonnullOwnPtr<UCICommand>> UCICommand::from_string(StringView command)
return adopt_nonnull_own_or_enomem(new (nothrow) UCICommand); return adopt_nonnull_own_or_enomem(new (nothrow) UCICommand);
} }
DeprecatedString UCICommand::to_deprecated_string() const ErrorOr<String> UCICommand::to_string() const
{ {
return "uci\n"; return "uci\n"_short_string;
} }
ErrorOr<NonnullOwnPtr<DebugCommand>> DebugCommand::from_string(StringView command) ErrorOr<NonnullOwnPtr<DebugCommand>> DebugCommand::from_string(StringView command)
@ -35,12 +36,12 @@ ErrorOr<NonnullOwnPtr<DebugCommand>> DebugCommand::from_string(StringView comman
VERIFY_NOT_REACHED(); VERIFY_NOT_REACHED();
} }
DeprecatedString DebugCommand::to_deprecated_string() const ErrorOr<String> DebugCommand::to_string() const
{ {
if (flag() == Flag::On) { if (flag() == Flag::On) {
return "debug on\n"; return "debug on\n"_string;
} else { } else {
return "debug off\n"; return "debug off\n"_string;
} }
} }
@ -52,9 +53,9 @@ ErrorOr<NonnullOwnPtr<IsReadyCommand>> IsReadyCommand::from_string(StringView co
return adopt_nonnull_own_or_enomem(new (nothrow) IsReadyCommand); return adopt_nonnull_own_or_enomem(new (nothrow) IsReadyCommand);
} }
DeprecatedString IsReadyCommand::to_deprecated_string() const ErrorOr<String> IsReadyCommand::to_string() const
{ {
return "isready\n"; return "isready\n"_string;
} }
ErrorOr<NonnullOwnPtr<SetOptionCommand>> SetOptionCommand::from_string(StringView command) ErrorOr<NonnullOwnPtr<SetOptionCommand>> SetOptionCommand::from_string(StringView command)
@ -92,20 +93,22 @@ ErrorOr<NonnullOwnPtr<SetOptionCommand>> SetOptionCommand::from_string(StringVie
VERIFY(!name.is_empty()); VERIFY(!name.is_empty());
return adopt_nonnull_own_or_enomem(new (nothrow) SetOptionCommand(name.to_deprecated_string().trim_whitespace(), value.to_deprecated_string().trim_whitespace())); return adopt_nonnull_own_or_enomem(new (nothrow) SetOptionCommand(
TRY(String::from_utf8(name.string_view().trim_whitespace())),
TRY(String::from_utf8(value.string_view().trim_whitespace()))));
} }
DeprecatedString SetOptionCommand::to_deprecated_string() const ErrorOr<String> SetOptionCommand::to_string() const
{ {
StringBuilder builder; StringBuilder builder;
builder.append("setoption name "sv); TRY(builder.try_append("setoption name "sv));
builder.append(name()); TRY(builder.try_append(name()));
if (value().has_value()) { if (value().has_value()) {
builder.append(" value "sv); TRY(builder.try_append(" value "sv));
builder.append(value().value()); TRY(builder.try_append(value().value()));
} }
builder.append('\n'); TRY(builder.try_append('\n'));
return builder.to_deprecated_string(); return builder.to_string();
} }
ErrorOr<NonnullOwnPtr<PositionCommand>> PositionCommand::from_string(StringView command) ErrorOr<NonnullOwnPtr<PositionCommand>> PositionCommand::from_string(StringView command)
@ -115,9 +118,9 @@ ErrorOr<NonnullOwnPtr<PositionCommand>> PositionCommand::from_string(StringView
VERIFY(tokens[0] == "position"); VERIFY(tokens[0] == "position");
VERIFY(tokens[2] == "moves"); VERIFY(tokens[2] == "moves");
Optional<DeprecatedString> fen; Optional<String> fen;
if (tokens[1] != "startpos") if (tokens[1] != "startpos")
fen = tokens[1]; fen = TRY(String::from_utf8(tokens[1]));
Vector<Move> moves; Vector<Move> moves;
for (size_t i = 3; i < tokens.size(); ++i) { for (size_t i = 3; i < tokens.size(); ++i) {
@ -126,22 +129,22 @@ ErrorOr<NonnullOwnPtr<PositionCommand>> PositionCommand::from_string(StringView
return adopt_nonnull_own_or_enomem(new (nothrow) PositionCommand(fen, moves)); return adopt_nonnull_own_or_enomem(new (nothrow) PositionCommand(fen, moves));
} }
DeprecatedString PositionCommand::to_deprecated_string() const ErrorOr<String> PositionCommand::to_string() const
{ {
StringBuilder builder; StringBuilder builder;
builder.append("position "sv); TRY(builder.try_append("position "sv));
if (fen().has_value()) { if (fen().has_value()) {
builder.append(fen().value()); TRY(builder.try_append(fen().value()));
} else { } else {
builder.append("startpos "sv); TRY(builder.try_append("startpos "sv));
} }
builder.append("moves"sv); TRY(builder.try_append("moves"sv));
for (auto& move : moves()) { for (auto& move : moves()) {
builder.append(' '); TRY(builder.try_append(' '));
builder.append(move.to_long_algebraic()); TRY(builder.try_append(move.to_long_algebraic()));
} }
builder.append('\n'); TRY(builder.try_append('\n'));
return builder.to_deprecated_string(); return builder.to_string();
} }
ErrorOr<NonnullOwnPtr<GoCommand>> GoCommand::from_string(StringView command) ErrorOr<NonnullOwnPtr<GoCommand>> GoCommand::from_string(StringView command)
@ -190,44 +193,44 @@ ErrorOr<NonnullOwnPtr<GoCommand>> GoCommand::from_string(StringView command)
return go_command; return go_command;
} }
DeprecatedString GoCommand::to_deprecated_string() const ErrorOr<String> GoCommand::to_string() const
{ {
StringBuilder builder; StringBuilder builder;
builder.append("go"sv); TRY(builder.try_append("go"sv));
if (searchmoves.has_value()) { if (searchmoves.has_value()) {
builder.append(" searchmoves"sv); TRY(builder.try_append(" searchmoves"sv));
for (auto& move : searchmoves.value()) { for (auto& move : searchmoves.value()) {
builder.append(' '); TRY(builder.try_append(' '));
builder.append(move.to_long_algebraic()); TRY(builder.try_append(move.to_long_algebraic()));
} }
} }
if (ponder) if (ponder)
builder.append(" ponder"sv); TRY(builder.try_append(" ponder"sv));
if (wtime.has_value()) if (wtime.has_value())
builder.appendff(" wtime {}", wtime.value()); TRY(builder.try_appendff(" wtime {}", wtime.value()));
if (btime.has_value()) if (btime.has_value())
builder.appendff(" btime {}", btime.value()); TRY(builder.try_appendff(" btime {}", btime.value()));
if (winc.has_value()) if (winc.has_value())
builder.appendff(" winc {}", winc.value()); TRY(builder.try_appendff(" winc {}", winc.value()));
if (binc.has_value()) if (binc.has_value())
builder.appendff(" binc {}", binc.value()); TRY(builder.try_appendff(" binc {}", binc.value()));
if (movestogo.has_value()) if (movestogo.has_value())
builder.appendff(" movestogo {}", movestogo.value()); TRY(builder.try_appendff(" movestogo {}", movestogo.value()));
if (depth.has_value()) if (depth.has_value())
builder.appendff(" depth {}", depth.value()); TRY(builder.try_appendff(" depth {}", depth.value()));
if (nodes.has_value()) if (nodes.has_value())
builder.appendff(" nodes {}", nodes.value()); TRY(builder.try_appendff(" nodes {}", nodes.value()));
if (mate.has_value()) if (mate.has_value())
builder.appendff(" mate {}", mate.value()); TRY(builder.try_appendff(" mate {}", mate.value()));
if (movetime.has_value()) if (movetime.has_value())
builder.appendff(" movetime {}", movetime.value()); TRY(builder.try_appendff(" movetime {}", movetime.value()));
if (infinite) if (infinite)
builder.append(" infinite"sv); TRY(builder.try_append(" infinite"sv));
builder.append('\n'); TRY(builder.try_append('\n'));
return builder.to_deprecated_string(); return builder.to_string();
} }
ErrorOr<NonnullOwnPtr<StopCommand>> StopCommand::from_string(StringView command) ErrorOr<NonnullOwnPtr<StopCommand>> StopCommand::from_string(StringView command)
@ -238,9 +241,9 @@ ErrorOr<NonnullOwnPtr<StopCommand>> StopCommand::from_string(StringView command)
return adopt_nonnull_own_or_enomem(new (nothrow) StopCommand); return adopt_nonnull_own_or_enomem(new (nothrow) StopCommand);
} }
DeprecatedString StopCommand::to_deprecated_string() const ErrorOr<String> StopCommand::to_string() const
{ {
return "stop\n"; return "stop\n"_short_string;
} }
ErrorOr<NonnullOwnPtr<IdCommand>> IdCommand::from_string(StringView command) ErrorOr<NonnullOwnPtr<IdCommand>> IdCommand::from_string(StringView command)
@ -256,25 +259,25 @@ ErrorOr<NonnullOwnPtr<IdCommand>> IdCommand::from_string(StringView command)
} }
if (tokens[1] == "name") { if (tokens[1] == "name") {
return adopt_nonnull_own_or_enomem(new (nothrow) IdCommand(Type::Name, value.to_deprecated_string())); return adopt_nonnull_own_or_enomem(new (nothrow) IdCommand(Type::Name, TRY(value.to_string())));
} else if (tokens[1] == "author") { } else if (tokens[1] == "author") {
return adopt_nonnull_own_or_enomem(new (nothrow) IdCommand(Type::Author, value.to_deprecated_string())); return adopt_nonnull_own_or_enomem(new (nothrow) IdCommand(Type::Author, TRY(value.to_string())));
} }
VERIFY_NOT_REACHED(); VERIFY_NOT_REACHED();
} }
DeprecatedString IdCommand::to_deprecated_string() const ErrorOr<String> IdCommand::to_string() const
{ {
StringBuilder builder; StringBuilder builder;
builder.append("id "sv); TRY(builder.try_append("id "sv));
if (field_type() == Type::Name) { if (field_type() == Type::Name) {
builder.append("name "sv); TRY(builder.try_append("name "sv));
} else { } else {
builder.append("author "sv); TRY(builder.try_append("author "sv));
} }
builder.append(value()); TRY(builder.try_append(value()));
builder.append('\n'); TRY(builder.try_append('\n'));
return builder.to_deprecated_string(); return builder.to_string();
} }
ErrorOr<NonnullOwnPtr<UCIOkCommand>> UCIOkCommand::from_string(StringView command) ErrorOr<NonnullOwnPtr<UCIOkCommand>> UCIOkCommand::from_string(StringView command)
@ -285,9 +288,9 @@ ErrorOr<NonnullOwnPtr<UCIOkCommand>> UCIOkCommand::from_string(StringView comman
return adopt_nonnull_own_or_enomem(new (nothrow) UCIOkCommand); return adopt_nonnull_own_or_enomem(new (nothrow) UCIOkCommand);
} }
DeprecatedString UCIOkCommand::to_deprecated_string() const ErrorOr<String> UCIOkCommand::to_string() const
{ {
return "uciok\n"; return "uciok\n"_short_string;
} }
ErrorOr<NonnullOwnPtr<ReadyOkCommand>> ReadyOkCommand::from_string(StringView command) ErrorOr<NonnullOwnPtr<ReadyOkCommand>> ReadyOkCommand::from_string(StringView command)
@ -298,9 +301,9 @@ ErrorOr<NonnullOwnPtr<ReadyOkCommand>> ReadyOkCommand::from_string(StringView co
return adopt_nonnull_own_or_enomem(new (nothrow) ReadyOkCommand); return adopt_nonnull_own_or_enomem(new (nothrow) ReadyOkCommand);
} }
DeprecatedString ReadyOkCommand::to_deprecated_string() const ErrorOr<String> ReadyOkCommand::to_string() const
{ {
return "readyok\n"; return "readyok\n"_string;
} }
ErrorOr<NonnullOwnPtr<BestMoveCommand>> BestMoveCommand::from_string(StringView command) ErrorOr<NonnullOwnPtr<BestMoveCommand>> BestMoveCommand::from_string(StringView command)
@ -311,13 +314,13 @@ ErrorOr<NonnullOwnPtr<BestMoveCommand>> BestMoveCommand::from_string(StringView
return adopt_nonnull_own_or_enomem(new (nothrow) BestMoveCommand(Move(tokens[1]))); return adopt_nonnull_own_or_enomem(new (nothrow) BestMoveCommand(Move(tokens[1])));
} }
DeprecatedString BestMoveCommand::to_deprecated_string() const ErrorOr<String> BestMoveCommand::to_string() const
{ {
StringBuilder builder; StringBuilder builder;
builder.append("bestmove "sv); TRY(builder.try_append("bestmove "sv));
builder.append(move().to_long_algebraic()); TRY(builder.try_append(move().to_long_algebraic()));
builder.append('\n'); TRY(builder.try_append('\n'));
return builder.to_deprecated_string(); return builder.to_string();
} }
ErrorOr<NonnullOwnPtr<InfoCommand>> InfoCommand::from_string([[maybe_unused]] StringView command) ErrorOr<NonnullOwnPtr<InfoCommand>> InfoCommand::from_string([[maybe_unused]] StringView command)
@ -326,11 +329,10 @@ ErrorOr<NonnullOwnPtr<InfoCommand>> InfoCommand::from_string([[maybe_unused]] St
VERIFY_NOT_REACHED(); VERIFY_NOT_REACHED();
} }
DeprecatedString InfoCommand::to_deprecated_string() const ErrorOr<String> InfoCommand::to_string() const
{ {
// FIXME: Implement this. // FIXME: Implement this.
VERIFY_NOT_REACHED(); VERIFY_NOT_REACHED();
return "info";
} }
ErrorOr<NonnullOwnPtr<QuitCommand>> QuitCommand::from_string(StringView command) ErrorOr<NonnullOwnPtr<QuitCommand>> QuitCommand::from_string(StringView command)
@ -341,9 +343,9 @@ ErrorOr<NonnullOwnPtr<QuitCommand>> QuitCommand::from_string(StringView command)
return adopt_nonnull_own_or_enomem(new (nothrow) QuitCommand); return adopt_nonnull_own_or_enomem(new (nothrow) QuitCommand);
} }
DeprecatedString QuitCommand::to_deprecated_string() const ErrorOr<String> QuitCommand::to_string() const
{ {
return "quit\n"; return "quit\n"_short_string;
} }
} }

52
Userland/Libraries/LibChess/UCICommand.h
View file

@ -7,8 +7,8 @@
#pragma once #pragma once
#include <AK/DeprecatedString.h>
#include <AK/Optional.h> #include <AK/Optional.h>
#include <AK/String.h>
#include <LibChess/Chess.h> #include <LibChess/Chess.h>
#include <LibCore/Event.h> #include <LibCore/Event.h>
@ -39,7 +39,7 @@ public:
Info, Info,
Option, Option,
}; };
virtual DeprecatedString to_deprecated_string() const = 0; virtual ErrorOr<String> to_string() const = 0;
virtual ~Command() = default; virtual ~Command() = default;
@ -59,7 +59,7 @@ public:
static ErrorOr<NonnullOwnPtr<UCICommand>> from_string(StringView command); static ErrorOr<NonnullOwnPtr<UCICommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override; virtual ErrorOr<String> to_string() const override;
}; };
class DebugCommand : public Command { class DebugCommand : public Command {
@ -77,7 +77,7 @@ public:
static ErrorOr<NonnullOwnPtr<DebugCommand>> from_string(StringView command); static ErrorOr<NonnullOwnPtr<DebugCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override; virtual ErrorOr<String> to_string() const override;
Flag flag() const { return m_flag; } Flag flag() const { return m_flag; }
@ -94,12 +94,12 @@ public:
static ErrorOr<NonnullOwnPtr<IsReadyCommand>> from_string(StringView command); static ErrorOr<NonnullOwnPtr<IsReadyCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override; virtual ErrorOr<String> to_string() const override;
}; };
class SetOptionCommand : public Command { class SetOptionCommand : public Command {
public: public:
explicit SetOptionCommand(StringView name, Optional<DeprecatedString> value = {}) explicit SetOptionCommand(String name, Optional<String> value = {})
: Command(Command::Type::SetOption) : Command(Command::Type::SetOption)
, m_name(name) , m_name(name)
, m_value(value) , m_value(value)
@ -108,19 +108,19 @@ public:
static ErrorOr<NonnullOwnPtr<SetOptionCommand>> from_string(StringView command); static ErrorOr<NonnullOwnPtr<SetOptionCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override; virtual ErrorOr<String> to_string() const override;
DeprecatedString const& name() const { return m_name; } String const& name() const { return m_name; }
Optional<DeprecatedString> const& value() const { return m_value; } Optional<String> const& value() const { return m_value; }
private: private:
DeprecatedString m_name; String m_name;
Optional<DeprecatedString> m_value; Optional<String> m_value;
}; };
class PositionCommand : public Command { class PositionCommand : public Command {
public: public:
explicit PositionCommand(Optional<DeprecatedString> const& fen, Vector<Chess::Move> const& moves) explicit PositionCommand(Optional<String> const& fen, Vector<Chess::Move> const& moves)
: Command(Command::Type::Position) : Command(Command::Type::Position)
, m_fen(fen) , m_fen(fen)
, m_moves(moves) , m_moves(moves)
@ -129,13 +129,13 @@ public:
static ErrorOr<NonnullOwnPtr<PositionCommand>> from_string(StringView command); static ErrorOr<NonnullOwnPtr<PositionCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override; virtual ErrorOr<String> to_string() const override;
Optional<DeprecatedString> const& fen() const { return m_fen; } Optional<String> const& fen() const { return m_fen; }
Vector<Chess::Move> const& moves() const { return m_moves; } Vector<Chess::Move> const& moves() const { return m_moves; }
private: private:
Optional<DeprecatedString> m_fen; Optional<String> m_fen;
Vector<Chess::Move> m_moves; Vector<Chess::Move> m_moves;
}; };
@ -148,7 +148,7 @@ public:
static ErrorOr<NonnullOwnPtr<GoCommand>> from_string(StringView command); static ErrorOr<NonnullOwnPtr<GoCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override; virtual ErrorOr<String> to_string() const override;
Optional<Vector<Chess::Move>> searchmoves; Optional<Vector<Chess::Move>> searchmoves;
bool ponder { false }; bool ponder { false };
@ -173,7 +173,7 @@ public:
static ErrorOr<NonnullOwnPtr<StopCommand>> from_string(StringView command); static ErrorOr<NonnullOwnPtr<StopCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override; virtual ErrorOr<String> to_string() const override;
}; };
class IdCommand : public Command { class IdCommand : public Command {
@ -183,7 +183,7 @@ public:
Author, Author,
}; };
explicit IdCommand(Type field_type, StringView value) explicit IdCommand(Type field_type, String value)
: Command(Command::Type::Id) : Command(Command::Type::Id)
, m_field_type(field_type) , m_field_type(field_type)
, m_value(value) , m_value(value)
@ -192,14 +192,14 @@ public:
static ErrorOr<NonnullOwnPtr<IdCommand>> from_string(StringView command); static ErrorOr<NonnullOwnPtr<IdCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override; virtual ErrorOr<String> to_string() const override;
Type field_type() const { return m_field_type; } Type field_type() const { return m_field_type; }
DeprecatedString const& value() const { return m_value; } String const& value() const { return m_value; }
private: private:
Type m_field_type; Type m_field_type;
DeprecatedString m_value; String m_value;
}; };
class UCIOkCommand : public Command { class UCIOkCommand : public Command {
@ -211,7 +211,7 @@ public:
static ErrorOr<NonnullOwnPtr<UCIOkCommand>> from_string(StringView command); static ErrorOr<NonnullOwnPtr<UCIOkCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override; virtual ErrorOr<String> to_string() const override;
}; };
class ReadyOkCommand : public Command { class ReadyOkCommand : public Command {
@ -223,7 +223,7 @@ public:
static ErrorOr<NonnullOwnPtr<ReadyOkCommand>> from_string(StringView command); static ErrorOr<NonnullOwnPtr<ReadyOkCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override; virtual ErrorOr<String> to_string() const override;
}; };
class BestMoveCommand : public Command { class BestMoveCommand : public Command {
@ -236,7 +236,7 @@ public:
static ErrorOr<NonnullOwnPtr<BestMoveCommand>> from_string(StringView command); static ErrorOr<NonnullOwnPtr<BestMoveCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override; virtual ErrorOr<String> to_string() const override;
Chess::Move move() const { return m_move; } Chess::Move move() const { return m_move; }
@ -253,7 +253,7 @@ public:
static ErrorOr<NonnullOwnPtr<InfoCommand>> from_string(StringView command); static ErrorOr<NonnullOwnPtr<InfoCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override; virtual ErrorOr<String> to_string() const override;
Optional<int> depth; Optional<int> depth;
Optional<int> seldepth; Optional<int> seldepth;
@ -278,7 +278,7 @@ public:
static ErrorOr<NonnullOwnPtr<QuitCommand>> from_string(StringView command); static ErrorOr<NonnullOwnPtr<QuitCommand>> from_string(StringView command);
virtual DeprecatedString to_deprecated_string() const override; virtual ErrorOr<String> to_string() const override;
}; };
} }

5
Userland/Libraries/LibChess/UCIEndpoint.cpp
View file

@ -22,8 +22,9 @@ Endpoint::Endpoint(NonnullRefPtr<Core::IODevice> in, NonnullRefPtr<Core::IODevic
void Endpoint::send_command(Command const& command) void Endpoint::send_command(Command const& command)
{ {
dbgln_if(UCI_DEBUG, "{} Sent UCI Command: {}", class_name(), DeprecatedString(command.to_deprecated_string().characters(), Chomp)); auto command_string = command.to_string().release_value_but_fixme_should_propagate_errors();
m_out->write(command.to_deprecated_string()); dbgln_if(UCI_DEBUG, "{} Sent UCI Command: {}", class_name(), command_string);
m_out->write(command_string);
} }
void Endpoint::event(Core::Event& event) void Endpoint::event(Core::Event& event)

4
Userland/Services/ChessEngine/ChessEngine.cpp
View file

@ -14,8 +14,8 @@ using namespace Chess::UCI;
void ChessEngine::handle_uci() void ChessEngine::handle_uci()
{ {
send_command(IdCommand(IdCommand::Type::Name, "ChessEngine"sv)); send_command(IdCommand(IdCommand::Type::Name, "ChessEngine"_string.release_value_but_fixme_should_propagate_errors()));
send_command(IdCommand(IdCommand::Type::Author, "the SerenityOS developers"sv)); send_command(IdCommand(IdCommand::Type::Author, "the SerenityOS developers"_string.release_value_but_fixme_should_propagate_errors()));
send_command(UCIOkCommand()); send_command(UCIOkCommand());
} }