From 29ee57634545ec3f05e870e7005419226b593e99 Mon Sep 17 00:00:00 2001 From: Bastiaan van der Plaat Date: Wed, 20 Dec 2023 18:17:32 +0100 Subject: [PATCH] LibWeb: Fix select dropdown position when scrolled on a page --- Ladybird/Qt/Tab.cpp | 2 +- Userland/Libraries/LibWebView/WebContentClient.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Ladybird/Qt/Tab.cpp b/Ladybird/Qt/Tab.cpp index 5466ba9ad0..7ae21f96ab 100644 --- a/Ladybird/Qt/Tab.cpp +++ b/Ladybird/Qt/Tab.cpp @@ -234,7 +234,7 @@ Tab::Tab(BrowserWindow* window, WebContentOptions const& web_content_options, St view().on_request_select_dropdown = [this](Gfx::IntPoint content_position, i32 minimum_width, Vector items) { m_select_dropdown->clear(); - m_select_dropdown->setMinimumWidth(minimum_width); + m_select_dropdown->setMinimumWidth(minimum_width / view().device_pixel_ratio()); for (auto const& item : items) { select_dropdown_add_item(m_select_dropdown, item); } diff --git a/Userland/Libraries/LibWebView/WebContentClient.cpp b/Userland/Libraries/LibWebView/WebContentClient.cpp index 98c148ee0f..9609b4c325 100644 --- a/Userland/Libraries/LibWebView/WebContentClient.cpp +++ b/Userland/Libraries/LibWebView/WebContentClient.cpp @@ -366,7 +366,7 @@ void WebContentClient::did_request_color_picker(Color const& current_color) void WebContentClient::did_request_select_dropdown(Gfx::IntPoint content_position, i32 minimum_width, Vector const& items) { if (m_view.on_request_select_dropdown) - m_view.on_request_select_dropdown(m_view.to_widget_position(content_position), m_view.to_widget_position(Gfx::IntPoint { minimum_width, 0 }).x(), items); + m_view.on_request_select_dropdown(content_position, minimum_width, items); } void WebContentClient::did_finish_handling_input_event(bool event_was_accepted)