RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 18:27:35 +00:00
Code Issues Activity Actions

LibWeb: Consider cell computed height in total row min height of table

Browse source 
Previously, the minimum height of a table row was calculated based
on the automatic height of the cells inner layout. This change makes
computed height of a cell boxes also be considered if it has definite
value.
This commit is contained in:
Aliaksandr Kalenik 2023-04-28 02:43:48 +03:00 • committed by Andreas Kling
parent 9b4cd0dab7
commit 2a1e58f8cc
4 changed files with 43 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Tests/LibWeb/Layout/expected/css-pseudo-element-should-not-be-affected-by-presentational-hints.txt
View file

@ -1,13 +1,13 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x47.835937 children: not-inline
BlockContainer <body> at (10,10) content-size 780x29.835937 children: not-inline
TableWrapper <(anonymous)> at (10,10) content-size 104x29.835937 children: not-inline
TableBox <table> at (11,11) content-size 104x27.835937 children: not-inline
TableRowGroupBox <tbody> at (11,11) content-size 104x27.835937 children: not-inline
TableRowBox <tr> at (11,11) content-size 104x27.835937 children: not-inline
TableCellBox <td> at (13,13) content-size 100x23.835937 children: not-inline
BlockContainer <(anonymous)> at (14,14) content-size 98x21.835937 children: inline
BlockContainer <html> at (1,1) content-size 798x120 children: not-inline
BlockContainer <body> at (10,10) content-size 780x102 children: not-inline
TableWrapper <(anonymous)> at (10,10) content-size 104x102 children: not-inline
TableBox <table> at (11,11) content-size 104x100 children: not-inline
TableRowGroupBox <tbody> at (11,11) content-size 104x100 children: not-inline
TableRowBox <tr> at (11,11) content-size 104x100 children: not-inline
TableCellBox <td> at (13,49.082031) content-size 100x23.835937 children: not-inline
BlockContainer <(anonymous)> at (14,50.082031) content-size 98x21.835937 children: inline
line 0 width: 0, height: 21.835937, bottom: 21.835937, baseline: 16.914062
frag 0 from TextNode start: 0, length: 0, rect: [14,14 0x21.835937]
frag 0 from TextNode start: 0, length: 0, rect: [14,50.082031 0x21.835937]
""
TextNode <#text>

6
Tests/LibWeb/Layout/expected/table/cell-px-height.txt Normal file
View file

@ -0,0 +1,6 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x116 children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 102x100 children: not-inline
TableBox <body> at (8,8) content-size 102x100 children: not-inline
TableRowBox <div.row> at (8,8) content-size 102x100 children: not-inline
TableCellBox <div.cell> at (9,9) content-size 100x0 children: not-inline

17
Tests/LibWeb/Layout/input/table/cell-px-height.html Normal file
View file

@ -0,0 +1,17 @@
<style>
body {
display: table;
}
.row {
display: table-row;
}
.cell {
display: table-cell;
border: 1px solid black;
width: 100px;
height: 100px;
}
</style>
<div class="row"><div class="cell"></div></div>