RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:47:34 +00:00
Code Issues Activity Actions

LibCrypto: Avoid UB in BigFraction::to_byte_string for 0/x fractions

Browse source
This commit is contained in:
Dan Klishch 2024-02-08 14:39:26 -05:00 • committed by Andrew Kaster
parent bd26e5dce9
commit 2a2e31f2ed
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCrypto/BigFraction/BigFraction.cpp
View file

@ -213,7 +213,7 @@ ByteString BigFraction::to_byte_string(unsigned rounding_threshold) const
auto const remove_trailing_zeros = [](StringView value) -> StringView {
auto n = value.length();
VERIFY(n > 0);
while (value.characters_without_null_termination()[n - 1] == '0')
while (n > 0 && value.characters_without_null_termination()[n - 1] == '0')
--n;
return { value.characters_without_null_termination(), n };
};