RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 17:38:12 +00:00
Code Issues Activity Actions

Kernel: Fix the return type for syscalls

Browse source 
The Process::Handler type has KResultOr<FlatPtr> as its return type.
Using a different return type with an equally-sized template parameter
sort of works but breaks once that condition is no longer true, e.g.
for KResultOr<int> on x86_64.

Ideally the syscall handlers would also take FlatPtrs as their args
so we can get rid of the reinterpret_cast for the function pointer
but I didn't quite feel like cleaning that up as well.
This commit is contained in:
Gunnar Beutner 2021-06-28 20:59:35 +02:00 • committed by Andreas Kling
parent b6435372cc
commit 2a78bf8596
71 changed files with 313 additions and 301 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Syscalls/kill.cpp
View file

@ -96,7 +96,7 @@ KResult Process::do_killself(int signal)
return KSuccess;
}
KResultOr<int> Process::sys$kill(pid_t pid_or_pgid, int signal)
KResultOr<FlatPtr> Process::sys$kill(pid_t pid_or_pgid, int signal)
{
if (pid_or_pgid == pid().value())
REQUIRE_PROMISE(stdio);
@ -123,7 +123,7 @@ KResultOr<int> Process::sys$kill(pid_t pid_or_pgid, int signal)
return do_kill(*peer, signal);
}
KResultOr<int> Process::sys$killpg(pid_t pgrp, int signum)
KResultOr<FlatPtr> Process::sys$killpg(pid_t pgrp, int signum)
{
REQUIRE_PROMISE(proc);
if (signum < 1 || signum >= 32)