RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:37:37 +00:00
Code Issues Activity Actions

LibJS: Throw TypeError on write to non-writable property in strict mode

Browse source
This commit is contained in:
Idan Horowitz 2021-06-06 00:43:03 +03:00 • committed by Linus Groh
parent 31534055e4
commit 2a8f4f097c
3 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/Object.cpp
View file

@ -637,6 +637,8 @@ bool Object::put_own_property(const StringOrSymbol& property_name, Value value,
auto value_here = m_storage[metadata.value().offset];
if (!new_property && mode == PutOwnPropertyMode::Put && !value_here.is_accessor() && !metadata.value().attributes.is_writable()) {
dbgln_if(OBJECT_DEBUG, "Disallow write to non-writable property");
if (throw_exceptions && vm().in_strict_mode())
vm().throw_exception<TypeError>(global_object(), ErrorType::DescWriteNonWritable, property_name.to_display_string());
return false;
}