RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 06:58:11 +00:00
Code Issues Activity Actions

Lagom: Fix leaks in the IDL Wrapper generator

Browse source 
By using RefPtrs to handle interfaces, the IDL parser could store cyclic
references to interfaces that import each other. One main example is the
"EventTarget.idl" and the "AbortSignal.idl" files, which both reference
each other. This caused huge amounts of memory not to be freed on exit.

To fix this, the parsed IDL interfaces are now stored in a HashTable of
NonnullOwnPtr<Interface>, which serves as the sole reference for every
parsed interface. All other usages of the Interface are changed to use
references instead of RefPtrs, or occasionally as raw pointers where
references don't fit inside the data structures.

This new HashTable is static, and as such will automatically be freed
prior to exiting the generator. This ensures that the code generator
properly cleans up after itself.

With this change, The IDL code generators can properly run on Lagom when
compiled with the -DENABLE_ADDRESS_SANITIZER=ON flag, and gets compiled
properly on the CI :^)
This commit is contained in:
DexesTTP 2022-04-30 19:27:50 +02:00 • committed by Linus Groh
parent 67f1ac5de7
commit 2ab8d474c6
4 changed files with 117 additions and 104 deletions
Download patch file Download diff file Expand all files Collapse all files

34
Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/main.cpp
View file

@ -83,21 +83,21 @@ int main(int argc, char** argv)
if (import_base_path.is_null())
import_base_path = lexical_path.dirname();
auto interface = IDL::Parser(path, data, import_base_path).parse();
auto& interface = IDL::Parser(path, data, import_base_path).parse();
if (namespace_.is_one_of("Crypto", "CSS", "DOM", "Encoding", "HTML", "UIEvents", "Geometry", "HighResolutionTime", "IntersectionObserver", "NavigationTiming", "RequestIdleCallback", "ResizeObserver", "SVG", "Selection", "URL", "WebSockets", "XHR")) {
StringBuilder builder;
builder.append(namespace_);
builder.append("::");
builder.append(interface->name);
interface->fully_qualified_name = builder.to_string();
builder.append(interface.name);
interface.fully_qualified_name = builder.to_string();
} else {
interface->fully_qualified_name = interface->name;
interface.fully_qualified_name = interface.name;
}
if constexpr (WRAPPER_GENERATOR_DEBUG) {
dbgln("Attributes:");
for (auto& attribute : interface->attributes) {
for (auto& attribute : interface.attributes) {
dbgln(" {}{}{} {}",
attribute.readonly ? "readonly " : "",
attribute.type->name,
@ -106,7 +106,7 @@ int main(int argc, char** argv)
}
dbgln("Functions:");
for (auto& function : interface->functions) {
for (auto& function : interface.functions) {
dbgln(" {}{} {}",
function.return_type->name,
function.return_type->nullable ? "?" : "",
@ -120,7 +120,7 @@ int main(int argc, char** argv)
}
dbgln("Static Functions:");
for (auto& function : interface->static_functions) {
for (auto& function : interface.static_functions) {
dbgln(" static {}{} {}",
function.return_type->name,
function.return_type->nullable ? "?" : "",
@ -135,34 +135,34 @@ int main(int argc, char** argv)
}
if (header_mode)
IDL::generate_header(*interface);
IDL::generate_header(interface);
if (implementation_mode)
IDL::generate_implementation(*interface);
IDL::generate_implementation(interface);
if (constructor_header_mode)
IDL::generate_constructor_header(*interface);
IDL::generate_constructor_header(interface);
if (constructor_implementation_mode)
IDL::generate_constructor_implementation(*interface);
IDL::generate_constructor_implementation(interface);
if (prototype_header_mode)
IDL::generate_prototype_header(*interface);
IDL::generate_prototype_header(interface);
if (prototype_implementation_mode)
IDL::generate_prototype_implementation(*interface);
IDL::generate_prototype_implementation(interface);
if (iterator_header_mode)
IDL::generate_iterator_header(*interface);
IDL::generate_iterator_header(interface);
if (iterator_implementation_mode)
IDL::generate_iterator_implementation(*interface);
IDL::generate_iterator_implementation(interface);
if (iterator_prototype_header_mode)
IDL::generate_iterator_prototype_header(*interface);
IDL::generate_iterator_prototype_header(interface);
if (iterator_prototype_implementation_mode)
IDL::generate_iterator_prototype_implementation(*interface);
IDL::generate_iterator_prototype_implementation(interface);
return 0;
}