RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00
Code Issues Activity Actions

LibGUI: Get rid of Model::ColumnMetadata and always use auto-sizing

Browse source 
Auto-sizing of view columns is now enabled by default. This removes the
last remaining need for ColumnMetadata, so this patch gets rid of it.
This commit is contained in:
Andreas Kling 2020-05-21 19:52:04 +02:00
parent c666c251c8
commit 2adb0a07e5
38 changed files with 1 additions and 216 deletions
Download patch file Download diff file Expand all files Collapse all files

1
DevTools/HackStudio/FindInFilesWidget.cpp
View file

@ -143,7 +143,6 @@ FindInFilesWidget::FindInFilesWidget()
m_button->set_preferred_size(100, 0);
m_result_view = add<GUI::TableView>();
m_result_view->set_size_columns_to_fit_content(true);
m_result_view->on_activation = [](auto& index) {
auto& match = *(const Match*)index.internal_data();

1
DevTools/HackStudio/Locator.cpp
View file

@ -151,7 +151,6 @@ Locator::Locator()
m_popup_window->set_rect(0, 0, 500, 200);
m_suggestion_view = m_popup_window->set_main_widget<GUI::TableView>();
m_suggestion_view->set_size_columns_to_fit_content(true);
m_suggestion_view->set_headers_visible(false);
m_suggestion_view->on_activation = [this](auto& index) {

1
DevTools/Inspector/main.cpp
View file

@ -94,7 +94,6 @@ int main(int argc, char** argv)
tree_view.set_activates_on_selection(true);
auto& properties_table_view = splitter.add<GUI::TableView>();
properties_table_view.set_size_columns_to_fit_content(true);
properties_table_view.set_editable(true);
properties_table_view.aid_create_editing_delegate = [](auto&) {
return make<GUI::StringModelEditingDelegate>();

2
DevTools/ProfileViewer/main.cpp
View file

@ -69,11 +69,9 @@ int main(int argc, char** argv)
auto& tree_view = bottom_splitter.add<GUI::TreeView>();
tree_view.set_headers_visible(true);
tree_view.set_size_columns_to_fit_content(true);
tree_view.set_model(profile->model());
auto& disassembly_view = bottom_splitter.add<GUI::TableView>();
disassembly_view.set_size_columns_to_fit_content(true);
tree_view.on_selection = [&](auto& index) {
profile->set_disassembly_index(index);

8
DevTools/VisualBuilder/VBWidgetPropertyModel.cpp
View file

@ -57,14 +57,6 @@ String VBWidgetPropertyModel::column_name(int column) const
}
}
GUI::Model::ColumnMetadata VBWidgetPropertyModel::column_metadata(int column) const
{
UNUSED_PARAM(column);
if (column == Column::Name)
return { 110 };
return { 90 };
}
GUI::Variant VBWidgetPropertyModel::data(const GUI::ModelIndex& index, Role role) const
{
if (role == Role::TextAlignment) {

1
DevTools/VisualBuilder/VBWidgetPropertyModel.h
View file

@ -46,7 +46,6 @@ public:
virtual int row_count(const GUI::ModelIndex&) const override;
virtual int column_count(const GUI::ModelIndex&) const override { return Column::__Count; }
virtual String column_name(int column) const override;
virtual ColumnMetadata column_metadata(int column) const override;
virtual GUI::Variant data(const GUI::ModelIndex&, Role = Role::Display) const override;
virtual void update() override { did_update(); }
virtual bool is_editable(const GUI::ModelIndex&) const override;