From 2afcd45299542cfdf6f933bbe580f904c40b2bab Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Sun, 3 Apr 2022 15:41:49 -0700 Subject: [PATCH] Meta: Suppress PVS Studio Rule v591 "non-void functions should return" This rule appears to be fundamentally broken for our code base, it flags `void` functions all over the place, as well as constructors. Lets suppress it for now. --- .github/workflows/pvs-studio-static-analysis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pvs-studio-static-analysis.yml b/.github/workflows/pvs-studio-static-analysis.yml index 89e6e16cfe..83043bd9a5 100644 --- a/.github/workflows/pvs-studio-static-analysis.yml +++ b/.github/workflows/pvs-studio-static-analysis.yml @@ -106,11 +106,12 @@ jobs: # - False positives: # V1047 Lifetime of the lambda is greater than lifetime of the local variable captured by reference. # V1076 Code contains invisible characters that may alter its logic. + # V591 Non-void function should return a value. # - name: Filter PVS Log working-directory: ${{ github.workspace }}/Build/${{ env.PVS_STUDIO_ANALYSIS_ARCH }} run: | - pvs-studio-analyzer suppress -v677 -v1061 -v530 -v1047 -v1076 project.plog + pvs-studio-analyzer suppress -v677 -v1061 -v530 -v1047 -v1076 -v591 project.plog pvs-studio-analyzer filter-suppressed project.plog - name: Print PVS Log