RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:27:35 +00:00
Code Issues Activity Actions

LibGUI: Reset TextEditor modified state on sucessful write_to_file

Browse source 
Avoids missing reset of the state if saving is done in multiple places.
This commit is contained in:
faxe1008 2021-05-16 21:30:46 +02:00 • committed by Linus Groh
parent 3cafdca868
commit 2b24fbdaaa
2 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Applications/TextEditor/MainWidget.cpp
View file

@ -302,8 +302,6 @@ MainWidget::MainWidget()
GUI::MessageBox::show(window(), "Unable to save file.\n", "Error", GUI::MessageBox::Type::Error); GUI::MessageBox::show(window(), "Unable to save file.\n", "Error", GUI::MessageBox::Type::Error);
return; return;
} }
editor().document().set_unmodified();
// FIXME: It would be cool if this would propagate from GUI::TextDocument somehow. // FIXME: It would be cool if this would propagate from GUI::TextDocument somehow.
window()->set_modified(false); window()->set_modified(false);
@ -316,7 +314,6 @@ MainWidget::MainWidget()
if (!m_editor->write_to_file(m_path)) { if (!m_editor->write_to_file(m_path)) {
GUI::MessageBox::show(window(), "Unable to save file.\n", "Error", GUI::MessageBox::Type::Error); GUI::MessageBox::show(window(), "Unable to save file.\n", "Error", GUI::MessageBox::Type::Error);
} else { } else {
editor().document().set_unmodified();
// FIXME: It would be cool if this would propagate from GUI::TextDocument somehow. // FIXME: It would be cool if this would propagate from GUI::TextDocument somehow.
window()->set_modified(false); window()->set_modified(false);

2
Userland/Libraries/LibGUI/TextEditor.cpp
View file

@ -1190,7 +1190,7 @@ bool TextEditor::write_to_file(const String& path)
return false; return false;
} }
} }
document().set_unmodified();
return true; return true;
} }