RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-23 21:55:08 +00:00
Code Issues Activity Actions

LibWeb: Don't crash in XHR.response{,XML} for empty XML document

Browse source 
There were some unhandled paths due to the liberally typed XHR response
object. This patch flushes out those issues by using a tighter type set
in the Variant. (NonnullGCPtr<Object> instead of Value)
This commit is contained in:
Andreas Kling 2023-10-07 07:57:16 +02:00
parent c21efdfc8a
commit 2b343c9508
6 changed files with 48 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Tests/LibWeb/Text/input/XMLHttpRequest-responseXML-empty.html Normal file
View file

@ -0,0 +1,16 @@
<script src="include.js"></script>
<script>
asyncTest((done) => {
const xhr = new XMLHttpRequest();
xhr.responseType = "document";
xhr.open("GET", "data:text/xml,", true);
xhr.onreadystatechange = function() {
if (xhr.readyState === 4 && xhr.status === 200) {
let xml = xhr.responseXML;
println("PASS"); // Didn't crash :^)
done();
}
};
xhr.send();
});
</script>