mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 15:37:46 +00:00
Tests: static vs non-static constexpr variables
Problem: - `static` variables consume memory and sometimes are less optimizable. - `static const` variables can be `constexpr`, usually. - `static` function-local variables require an initialization check every time the function is run. Solution: - If a global `static` variable is only used in a single function then move it into the function and make it non-`static` and `constexpr`. - Make all global `static` variables `constexpr` instead of `const`. - Change function-local `static const[expr]` variables to be just `constexpr`.
This commit is contained in:
parent
4aaf8df865
commit
2b64d163cd
6 changed files with 23 additions and 25 deletions
|
@ -87,7 +87,7 @@ static void randomize_from(size_t* buffer, size_t len, const Vector<size_t>& val
|
|||
|
||||
// The largest SC_*_params struct is SC_mmap_params with 36 bytes.
|
||||
static_assert(sizeof(size_t) == 4, "Cannot handle size_t != 4 bytes");
|
||||
static const size_t fake_params_count = 36 / sizeof(size_t);
|
||||
static constexpr size_t fake_params_count = 36 / sizeof(size_t);
|
||||
|
||||
static void do_weird_call(size_t attempt, int syscall_fn, size_t arg1, size_t arg2, size_t arg3, size_t* fake_params)
|
||||
{
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue