RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 10:37:44 +00:00
Code Issues Activity Actions

Tests: static vs non-static constexpr variables

Browse source 
Problem:
- `static` variables consume memory and sometimes are less
  optimizable.
- `static const` variables can be `constexpr`, usually.
- `static` function-local variables require an initialization check
  every time the function is run.

Solution:
- If a global `static` variable is only used in a single function then
  move it into the function and make it non-`static` and `constexpr`.
- Make all global `static` variables `constexpr` instead of `const`.
- Change function-local `static const[expr]` variables to be just
  `constexpr`.
This commit is contained in:
Lenny Maiorani 2021-05-19 08:54:19 -06:00 • committed by Linus Groh
parent 4aaf8df865
commit 2b64d163cd
6 changed files with 23 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Tests/LibC/accuracy-strtod.cpp
View file

@ -14,11 +14,11 @@
typedef char assert_size_t_is_int[sizeof(size_t) == 4 ? 1 : -1];
static const char* TEXT_ERROR = "\x1b[01;35m";
static const char* TEXT_WRONG = "\x1b[01;31m";
static const char* TEXT_OFBY1 = "\x1b[01;97m";
static const char* TEXT_RESET = "\x1b[0m";
static const long long LENIENCY = 8;
static constexpr char TEXT_ERROR[] = "\x1b[01;35m";
static constexpr char TEXT_WRONG[] = "\x1b[01;31m";
static constexpr char TEXT_OFBY1[] = "\x1b[01;97m";
static constexpr char TEXT_RESET[] = "\x1b[0m";
static constexpr long long LENIENCY = 8;
struct Testcase {
const char* test_name;

12
Tests/LibC/overlong_realpath.cpp
View file

@ -14,14 +14,14 @@
#include <unistd.h>
// FIXME
static const char* TEXT_FAIL = "\x1b[01;31m";
static const char* TEXT_PASS = "\x1b[01;32m";
static const char* TEXT_RESET = "\x1b[0m";
static constexpr char TEXT_FAIL[] = "\x1b[01;31m";
static constexpr char TEXT_PASS[] = "\x1b[01;32m";
static constexpr char TEXT_RESET[] = "\x1b[0m";
static const char* TMPDIR_PATTERN = "/tmp/overlong_realpath_XXXXXX";
static const char* PATH_LOREM_250 = "This-is-an-annoyingly-long-name-that-should-take-up-exactly-two-hundred-and-fifty-characters-and-is-surprisingly-difficult-to-fill-with-reasonably-meaningful-text-which-is-necessary-because-that-makes-it-easier-for-my-eyes-to-spot-any-corruption-fast";
static constexpr char TMPDIR_PATTERN[] = "/tmp/overlong_realpath_XXXXXX";
static constexpr char PATH_LOREM_250[] = "This-is-an-annoyingly-long-name-that-should-take-up-exactly-two-hundred-and-fifty-characters-and-is-surprisingly-difficult-to-fill-with-reasonably-meaningful-text-which-is-necessary-because-that-makes-it-easier-for-my-eyes-to-spot-any-corruption-fast";
static const size_t ITERATION_DEPTH = 17;
static constexpr size_t ITERATION_DEPTH = 17;
static bool check_result(const char* what, const String& expected, const char* actual)
{

4
Tests/LibC/snprintf-correctness.cpp
View file

@ -42,10 +42,10 @@ static String show(const ByteBuffer& buf)
return builder.build();
}
static const size_t SANDBOX_CANARY_SIZE = 8;
static bool test_single(const Testcase& testcase)
{
constexpr size_t SANDBOX_CANARY_SIZE = 8;
// Preconditions:
if (testcase.dest_n != testcase.dest_expected_n) {
warnln("dest length {} != expected dest length {}? Check testcase! (Probably miscounted.)", testcase.dest_n, testcase.dest_expected_n);

4
Tests/LibC/strlcpy-correctness.cpp
View file

@ -40,10 +40,10 @@ static String show(const ByteBuffer& buf)
return builder.build();
}
static const size_t SANDBOX_CANARY_SIZE = 8;
static bool test_single(const Testcase& testcase)
{
constexpr size_t SANDBOX_CANARY_SIZE = 8;
// Preconditions:
if (testcase.dest_n != testcase.dest_expected_n) {
warnln("dest length {} != expected dest length {}? Check testcase! (Probably miscounted.)", testcase.dest_n, testcase.dest_expected_n);