RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:37:35 +00:00
Code Issues Activity Actions

LibWeb: Clear element.style when the "style" attribute is removed

Browse source 
We were hanging on to element inline style, even after the style
attribute was removed. This made inline style sticky and impossible to
remove. This patch fixes that. :^)
This commit is contained in:
Andreas Kling 2022-03-20 16:31:40 +01:00
parent 485ef276bd
commit 2b7775118d
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -265,6 +265,16 @@ void Element::parse_attribute(const FlyString& name, const String& value)
}
}
void Element::did_remove_attribute(FlyString const& name)
{
if (name == HTML::AttributeNames::style) {
if (m_inline_style) {
m_inline_style = nullptr;
set_needs_style_update(true);
}
}
}
enum class RequiredInvalidation {
None,
RepaintOnly,

2
Userland/Libraries/LibWeb/DOM/Element.h
View file

@ -85,7 +85,7 @@ public:
virtual void apply_presentational_hints(CSS::StyleProperties&) const { }
virtual void parse_attribute(const FlyString& name, const String& value);
virtual void did_remove_attribute(FlyString const&) { }
virtual void did_remove_attribute(FlyString const&);
enum class NeedsRelayout {
No = 0,