RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 12:27:35 +00:00
Code Issues Activity Actions

LibJS: Add Sub bytecode instruction (subtract values)

Browse source
This commit is contained in:
Andreas Kling 2021-06-03 18:32:33 +02:00
parent 23a4448862
commit 2b9fbd10ed
3 changed files with 35 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibJS/AST.cpp
View file

@ -2264,12 +2264,15 @@ Optional<Bytecode::Register> BinaryExpression::generate_bytecode(Bytecode::Gener
VERIFY(lhs_reg.has_value()); VERIFY(lhs_reg.has_value());
VERIFY(rhs_reg.has_value()); VERIFY(rhs_reg.has_value());
auto dst_reg = generator.allocate_register();
switch (m_op) { switch (m_op) {
case BinaryOp::Addition: { case BinaryOp::Addition:
auto dst_reg = generator.allocate_register();
generator.emit<Bytecode::Op::Add>(dst_reg, *lhs_reg, *rhs_reg); generator.emit<Bytecode::Op::Add>(dst_reg, *lhs_reg, *rhs_reg);
return dst_reg; return dst_reg;
} case BinaryOp::Subtraction:
generator.emit<Bytecode::Op::Sub>(dst_reg, *lhs_reg, *rhs_reg);
return dst_reg;
default: default:
TODO(); TODO();
} }

10
Userland/Libraries/LibJS/Bytecode/Op.cpp
View file

@ -21,6 +21,11 @@ void Add::execute(Bytecode::Interpreter& interpreter) const
interpreter.reg(m_dst) = add(interpreter.global_object(), interpreter.reg(m_src1), interpreter.reg(m_src2)); interpreter.reg(m_dst) = add(interpreter.global_object(), interpreter.reg(m_src1), interpreter.reg(m_src2));
} }
void Sub::execute(Bytecode::Interpreter& interpreter) const
{
interpreter.reg(m_dst) = sub(interpreter.global_object(), interpreter.reg(m_src1), interpreter.reg(m_src2));
}
void NewString::execute(Bytecode::Interpreter& interpreter) const void NewString::execute(Bytecode::Interpreter& interpreter) const
{ {
interpreter.reg(m_dst) = js_string(interpreter.vm(), m_string); interpreter.reg(m_dst) = js_string(interpreter.vm(), m_string);
@ -46,6 +51,11 @@ String Add::to_string() const
return String::formatted("Add dst:{}, src1:{}, src2:{}", m_dst, m_src1, m_src2); return String::formatted("Add dst:{}, src1:{}, src2:{}", m_dst, m_src1, m_src2);
} }
String Sub::to_string() const
{
return String::formatted("Sub dst:{}, src1:{}, src2:{}", m_dst, m_src1, m_src2);
}
String NewString::to_string() const String NewString::to_string() const
{ {
return String::formatted("NewString dst:{}, string:\"{}\"", m_dst, m_string); return String::formatted("NewString dst:{}, string:\"{}\"", m_dst, m_string);

19
Userland/Libraries/LibJS/Bytecode/Op.h
View file

@ -50,6 +50,25 @@ private:
Register m_src2; Register m_src2;
}; };
class Sub final : public Instruction {
public:
Sub(Register dst, Register src1, Register src2)
: m_dst(dst)
, m_src1(src1)
, m_src2(src2)
{
}
virtual ~Sub() override { }
virtual void execute(Bytecode::Interpreter&) const override;
virtual String to_string() const override;
private:
Register m_dst;
Register m_src1;
Register m_src2;
};
class NewString final : public Instruction { class NewString final : public Instruction {
public: public:
NewString(Register dst, String string) NewString(Register dst, String string)