RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:37:44 +00:00
Code Issues Activity Actions

LibTLS: Avoid unnecessary HashMap copies, improve const-correctness

Browse source
This commit is contained in:
Ben Wiederhake 2023-05-13 20:51:24 +02:00 • committed by Jelle Raaijmakers
parent f866c80222
commit 2bb2a7097d
4 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibTLS/TLSv12.cpp
View file

@ -231,7 +231,7 @@ static bool wildcard_matches(StringView host, StringView subject)
return false;
}
static bool certificate_subject_matches_host(Certificate& cert, StringView host)
static bool certificate_subject_matches_host(Certificate const& cert, StringView host)
{
if (wildcard_matches(host, cert.subject.common_name()))
return true;
@ -269,7 +269,7 @@ bool Context::verify_chain(StringView host) const
// it in any case.
if (!host.is_empty()) {
auto first_certificate = local_chain->first();
auto const& first_certificate = local_chain->first();
auto subject_matches = certificate_subject_matches_host(first_certificate, host);
if (!subject_matches) {
dbgln("verify_chain: First certificate does not match the hostname");
@ -282,7 +282,7 @@ bool Context::verify_chain(StringView host) const
}
for (size_t cert_index = 0; cert_index < local_chain->size(); ++cert_index) {
auto cert = local_chain->at(cert_index);
auto const& cert = local_chain->at(cert_index);
auto subject_string = MUST(cert.subject.to_string());
auto issuer_string = MUST(cert.issuer.to_string());
@ -316,7 +316,7 @@ bool Context::verify_chain(StringView host) const
return false;
}
auto parent_certificate = local_chain->at(cert_index + 1);
auto const& parent_certificate = local_chain->at(cert_index + 1);
if (issuer_string != MUST(parent_certificate.subject.to_string())) {
dbgln("verify_chain: Next certificate in the chain is not the issuer of this certificate");
return false;