RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 19:42:43 +00:00
Code Issues Activity Actions

LibJS: Don't update names of resulting functions in object expression

Browse source 
The only cases where the name should be set is if the function comes
from a direct anonymous function expression.
This commit is contained in:
davidot 2022-12-13 01:30:32 +01:00 • committed by Linus Groh
parent 897c7f7cc2
commit 2bbea62176
4 changed files with 63 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibJS/Parser.cpp
View file

@ -1779,7 +1779,10 @@ NonnullRefPtr<ObjectExpression> Parser::parse_object_expression()
}
if (is_proto && property_type == ObjectProperty::Type::KeyValue)
property_type = ObjectProperty::Type::ProtoSetter;
properties.append(create_ast_node<ObjectProperty>({ m_source_code, rule_start.position(), position() }, *property_key, parse_expression(2), property_type, false));
auto rhs_expression = parse_expression(2);
bool is_method = is<FunctionExpression>(*rhs_expression);
properties.append(create_ast_node<ObjectProperty>({ m_source_code, rule_start.position(), position() }, *property_key, move(rhs_expression), property_type, is_method));
} else if (property_key && property_value) {
if (m_state.strict_mode && is<StringLiteral>(*property_key)) {
auto& string_literal = static_cast<StringLiteral const&>(*property_key);