RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-16 14:32:09 +00:00
Code Issues Activity Actions

LibWeb: Teach CSS transformed StackingContexts about image-rendering

Browse source 
Previously, all StackingContexts which were scaled using CSS transforms
were hard-coded to use BilinearBlend. This fix maps specified
image-rendering properties to reasonable ScalingModes for painting.
This commit is contained in:
Valtteri Koskivuori 2023-06-08 23:57:53 +03:00 • committed by Andreas Kling
parent ac2238ee70
commit 2c5a062c8f
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/Painting/StackingContext.cpp
View file

@ -13,6 +13,7 @@
#include <LibGfx/Matrix4x4.h> #include <LibGfx/Matrix4x4.h>
#include <LibGfx/Painter.h> #include <LibGfx/Painter.h>
#include <LibGfx/Rect.h> #include <LibGfx/Rect.h>
#include <LibWeb/CSS/ComputedValues.h>
#include <LibWeb/CSS/StyleValues/TransformationStyleValue.h> #include <LibWeb/CSS/StyleValues/TransformationStyleValue.h>
#include <LibWeb/Layout/Box.h> #include <LibWeb/Layout/Box.h>
#include <LibWeb/Layout/ReplacedBox.h> #include <LibWeb/Layout/ReplacedBox.h>
@ -413,10 +414,12 @@ void StackingContext::paint(PaintContext& context) const
auto paint_context = context.clone(painter); auto paint_context = context.clone(painter);
paint_internal(paint_context); paint_internal(paint_context);
if (destination_rect.size() == bitmap->size()) if (destination_rect.size() == bitmap->size()) {
context.painter().blit(destination_rect.location(), *bitmap, bitmap->rect(), opacity); context.painter().blit(destination_rect.location(), *bitmap, bitmap->rect(), opacity);
else } else {
context.painter().draw_scaled_bitmap(destination_rect, *bitmap, bitmap->rect(), opacity, Gfx::Painter::ScalingMode::BilinearBlend); auto scaling_mode = CSS::to_gfx_scaling_mode(m_box->computed_values().image_rendering(), bitmap->rect(), destination_rect);
context.painter().draw_scaled_bitmap(destination_rect, *bitmap, bitmap->rect(), opacity, scaling_mode);
}
} else { } else {
Gfx::PainterStateSaver saver(context.painter()); Gfx::PainterStateSaver saver(context.painter());
context.painter().translate(affine_transform.translation().to_rounded<int>()); context.painter().translate(affine_transform.translation().to_rounded<int>());