RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 19:22:45 +00:00
Code Issues Activity Actions

LibLine: Initialize the search editor when entering search

Browse source 
Prior to this, no keybinding were installed on the search editor, and so
editing wasn't really possible.
Also fixes <C-r> making infinite search editors.
This commit is contained in:
AnotherTest 2020-08-20 08:07:27 +04:30 • committed by Andreas Kling
parent 688e54eac7
commit 2c5cc189c5
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibLine/InternalFunctions.cpp
View file

@ -232,6 +232,7 @@ void Editor::enter_search()
m_notifier->set_enabled(false);
m_search_editor = Editor::construct(Configuration { Configuration::Eager }); // Has anyone seen 'Inception'?
m_search_editor->initialize();
add_child(*m_search_editor);
m_search_editor->on_display_refresh = [this](Editor& search_editor) {
@ -239,7 +240,6 @@ void Editor::enter_search()
builder.append(Utf32View { search_editor.buffer().data(), search_editor.buffer().size() });
search(builder.build());
refresh_display();
return;
};
// Whenever the search editor gets a ^R, cycle between history entries.
@ -257,7 +257,9 @@ void Editor::enter_search()
search_editor.m_refresh_needed = true;
return false; // Do not process this key event
}
return true;
search_editor.erase_character_backwards();
return false;
});
// ^L - This is a source of issues, as the search editor refreshes first,