RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:07:45 +00:00
Code Issues Activity Actions

LibJS: Use Object* for 'manual' GlobalObject::foo_prototype() getters

Browse source 
Not doing so only leads to problems down the line, e.g. not being able
to pass them as function pointers to ordinary_create_from_constructor().
This commit is contained in:
Linus Groh 2022-05-05 20:43:51 +02:00
parent f3f19f8321
commit 2c68ec9097
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibJS/Runtime/GlobalObject.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2020-2022, Linus Groh <linusg@serenityos.org>
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -35,11 +36,11 @@ public:
ProxyConstructor* proxy_constructor() { return m_proxy_constructor; } ProxyConstructor* proxy_constructor() { return m_proxy_constructor; }
// Not included in JS_ENUMERATE_NATIVE_OBJECTS due to missing distinct constructor // Not included in JS_ENUMERATE_NATIVE_OBJECTS due to missing distinct constructor
GeneratorPrototype* generator_prototype() { return m_generator_prototype; } Object* async_from_sync_iterator_prototype() { return m_async_from_sync_iterator_prototype; }
AsyncFromSyncIteratorPrototype* async_from_sync_iterator_prototype() { return m_async_from_sync_iterator_prototype; } Object* generator_prototype() { return m_generator_prototype; }
// Not included in JS_ENUMERATE_INTL_OBJECTS due to missing distinct constructor // Not included in JS_ENUMERATE_INTL_OBJECTS due to missing distinct constructor
Intl::SegmentsPrototype* intl_segments_prototype() { return m_intl_segments_prototype; } Object* intl_segments_prototype() { return m_intl_segments_prototype; }
FunctionObject* array_prototype_values_function() const { return m_array_prototype_values_function; } FunctionObject* array_prototype_values_function() const { return m_array_prototype_values_function; }
FunctionObject* date_constructor_now_function() const { return m_date_constructor_now_function; } FunctionObject* date_constructor_now_function() const { return m_date_constructor_now_function; }
@ -107,11 +108,11 @@ private:
ProxyConstructor* m_proxy_constructor { nullptr }; ProxyConstructor* m_proxy_constructor { nullptr };
// Not included in JS_ENUMERATE_NATIVE_OBJECTS due to missing distinct constructor // Not included in JS_ENUMERATE_NATIVE_OBJECTS due to missing distinct constructor
GeneratorPrototype* m_generator_prototype { nullptr }; Object* m_async_from_sync_iterator_prototype { nullptr };
AsyncFromSyncIteratorPrototype* m_async_from_sync_iterator_prototype { nullptr }; Object* m_generator_prototype { nullptr };
// Not included in JS_ENUMERATE_INTL_OBJECTS due to missing distinct constructor // Not included in JS_ENUMERATE_INTL_OBJECTS due to missing distinct constructor
Intl::SegmentsPrototype* m_intl_segments_prototype { nullptr }; Object* m_intl_segments_prototype { nullptr };
FunctionObject* m_array_prototype_values_function { nullptr }; FunctionObject* m_array_prototype_values_function { nullptr };
FunctionObject* m_date_constructor_now_function { nullptr }; FunctionObject* m_date_constructor_now_function { nullptr };