RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:57:34 +00:00
Code Issues Activity Actions

LibGUI/AbstractView: Remove on_selection

Browse source 
Since the introduction of multi-select, we have had both `on_selection`
and `on_selection_change`, the latter of which was only invoked when a
change in selection came in through the model.

This removes `AbstractView::on_selection` and replaces it usage with
the more explicit `on_selection_change` everywhere.
This commit is contained in:
Jelle Raaijmakers 2021-05-25 22:48:43 +02:00 • committed by Ali Mohammad Pur
parent ebe38639bc
commit 2c772d1848
12 changed files with 36 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibGUI/FontPicker.cpp
View file

@ -56,7 +56,8 @@ FontPicker::FontPicker(Window* parent_window, const Gfx::Font* current_font, boo
});
quick_sort(m_families);
m_family_list_view->on_selection = [this](auto& index) {
m_family_list_view->on_selection_change = [this] {
const auto& index = m_family_list_view->selection().first();
m_family = index.data().to_string();
m_weights.clear();
Gfx::FontDatabase::the().for_each_typeface([&](auto& typeface) {
@ -76,7 +77,8 @@ FontPicker::FontPicker(Window* parent_window, const Gfx::Font* current_font, boo
update_font();
};
m_weight_list_view->on_selection = [this](auto& index) {
m_weight_list_view->on_selection_change = [this] {
const auto& index = m_weight_list_view->selection().first();
bool font_is_fixed_size = false;
m_weight = index.data(ModelRole::Custom).to_i32();
m_sizes.clear();
@ -130,7 +132,8 @@ FontPicker::FontPicker(Window* parent_window, const Gfx::Font* current_font, boo
update_font();
};
m_size_list_view->on_selection = [this](auto& index) {
m_size_list_view->on_selection_change = [this] {
const auto& index = m_size_list_view->selection().first();
m_size = index.data().to_i32();
m_size_spin_box->set_value(m_size.value());
update_font();