From 2c85f6551958028a556142965292d41423667b1f Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Sun, 31 Oct 2021 22:28:03 -0700 Subject: [PATCH] Kernel: Switch BIOSSysFSComponent constructor to AK::StringView These are constants, they don't need to be dynamically allocated. Another minor step towards removing `AK::String` from the Kernel and improving OOM safety. --- Kernel/Firmware/BIOS.cpp | 6 +++--- Kernel/Firmware/BIOS.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Kernel/Firmware/BIOS.cpp b/Kernel/Firmware/BIOS.cpp index 7cf117c44f..9bf9f5905c 100644 --- a/Kernel/Firmware/BIOS.cpp +++ b/Kernel/Firmware/BIOS.cpp @@ -24,7 +24,7 @@ UNMAP_AFTER_INIT NonnullRefPtr DMIEntryPointExposedBlo return adopt_ref(*new (nothrow) DMIEntryPointExposedBlob(dmi_entry_point, blob_size)); } -UNMAP_AFTER_INIT BIOSSysFSComponent::BIOSSysFSComponent(String name) +UNMAP_AFTER_INIT BIOSSysFSComponent::BIOSSysFSComponent(StringView name) : SysFSComponent(name) { } @@ -42,7 +42,7 @@ KResultOr BIOSSysFSComponent::read_bytes(off_t offset, size_t count, Use } UNMAP_AFTER_INIT DMIEntryPointExposedBlob::DMIEntryPointExposedBlob(PhysicalAddress dmi_entry_point, size_t blob_size) - : BIOSSysFSComponent("smbios_entry_point") + : BIOSSysFSComponent("smbios_entry_point"sv) , m_dmi_entry_point(dmi_entry_point) , m_dmi_entry_point_length(blob_size) { @@ -60,7 +60,7 @@ UNMAP_AFTER_INIT NonnullRefPtr SMBIOSExposedTable::create(Ph } UNMAP_AFTER_INIT SMBIOSExposedTable::SMBIOSExposedTable(PhysicalAddress smbios_structure_table, size_t smbios_structure_table_length) - : BIOSSysFSComponent("DMI") + : BIOSSysFSComponent("DMI"sv) , m_smbios_structure_table(smbios_structure_table) , m_smbios_structure_table_length(smbios_structure_table_length) { diff --git a/Kernel/Firmware/BIOS.h b/Kernel/Firmware/BIOS.h index aa7af999cb..8766d4a796 100644 --- a/Kernel/Firmware/BIOS.h +++ b/Kernel/Firmware/BIOS.h @@ -66,7 +66,7 @@ public: protected: virtual KResultOr> try_to_generate_buffer() const = 0; - explicit BIOSSysFSComponent(String name); + explicit BIOSSysFSComponent(StringView name); }; class DMIEntryPointExposedBlob : public BIOSSysFSComponent {