RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:18:13 +00:00
Code Issues Activity Actions

Kernel: Let InodeWatcher track child inode numbers instead of names

Browse source 
First of all, this fixes a dumb info leak where we'd write kernel heap
addresses (StringImpl*) into userspace memory when reading a watcher.

Instead of trying to pass names to userspace, we now simply pass the
child inode index. Nothing in userspace makes use of this yet anyway,
so it's not like we're breaking anything. We'll see how this evolves.
This commit is contained in:
Andreas Kling 2020-09-19 16:39:52 +02:00
parent 55dd13ccac
commit 2cb32f8356
6 changed files with 19 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/FileSystem/Inode.h
View file

@ -126,8 +126,8 @@ protected:
void inode_size_changed(size_t old_size, size_t new_size);
KResult prepare_to_write_data();
void did_add_child(const String& name);
void did_remove_child(const String& name);
void did_add_child(const InodeIdentifier&);
void did_remove_child(const InodeIdentifier&);
mutable Lock m_lock { "Inode" };