RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:37:35 +00:00
Code Issues Activity Actions

LibIPC+WindowServer+LibGUI: Detect and highlight unresponsive GUI apps

Browse source 
IPC::ClientConnection now tracks the time since the last time we got
a message from the client and calls a virtual function on itself after
3 seconds: may_have_become_unresponsive().

Subclasses of ClientConnection can then react to this if they like.

We use this mechanism in WindowServer to send out a friendly Ping
message to the client. If he doesn't Pong within 1 second, we mark
the client as "unresponsive" and recompose all of his windows with
a darkened appearance and amended title until he Pongs us.

This is a little on the aggressive side and we should figure out a way
to wake up less often. Perhaps this could only be done to windows the
user is currently interacting with, for example.

Anyways, this is pretty cool! :^)
This commit is contained in:
Andreas Kling 2020-06-11 22:46:49 +02:00
parent 940fbea3a7
commit 2ce2c4810a
9 changed files with 84 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Services/WindowServer/ClientConnection.h
View file

@ -50,7 +50,8 @@ class ClientConnection final
C_OBJECT(ClientConnection)
public:
~ClientConnection() override;
virtual void die() override;
bool is_unresponsive() const { return m_unresponsive; }
void boost();
void deboost();
@ -85,6 +86,11 @@ public:
private:
explicit ClientConnection(Core::LocalSocket&, int client_id);
// ^ClientConnection
virtual void die() override;
virtual void may_have_become_unresponsive() override;
void set_unresponsive(bool);
void destroy_window(Window&, Vector<i32>& destroyed_window_ids);
virtual OwnPtr<Messages::WindowServer::GreetResponse> handle(const Messages::WindowServer::Greet&) override;
@ -134,6 +140,7 @@ private:
virtual void handle(const Messages::WindowServer::EnableDisplayLink&) override;
virtual void handle(const Messages::WindowServer::DisableDisplayLink&) override;
virtual void handle(const Messages::WindowServer::SetWindowProgress&) override;
virtual void handle(const Messages::WindowServer::Pong&) override;
Window* window_from_id(i32 window_id);
@ -142,11 +149,14 @@ private:
HashMap<int, NonnullRefPtr<Menu>> m_menus;
WeakPtr<MenuBar> m_app_menubar;
RefPtr<Core::Timer> m_ping_timer;
int m_next_menubar_id { 10000 };
int m_next_menu_id { 20000 };
int m_next_window_id { 1982 };
bool m_has_display_link { false };
bool m_unresponsive { false };
};
}