RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 07:27:45 +00:00
Code Issues Activity Actions

LibAudio: Get rid of unused method Loader::file()

Browse source 
`aplay` and two files of `SoundPlayer` were relying on the include of
`LibCore/File.h` by `Loader.h`.
This commit is contained in:
Lucas CHOLLET 2022-10-12 18:20:39 +02:00 • committed by Linus Groh
parent 1444b42936
commit 2d6124049a
6 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibAudio/Loader.h
View file

@ -18,7 +18,6 @@
#include <LibAudio/LoaderError.h>
#include <LibAudio/Sample.h>
#include <LibAudio/SampleFormats.h>
#include <LibCore/File.h>
namespace Audio {
@ -54,7 +53,6 @@ public:
// Human-readable name of the file format, of the form <full abbreviation> (.<ending>)
virtual String format_name() = 0;
virtual PcmSampleFormat pcm_format() = 0;
virtual RefPtr<Core::File> file() = 0;
};
class Loader : public RefCounted<Loader> {
@ -73,7 +71,6 @@ public:
u16 num_channels() const { return m_plugin->num_channels(); }
String format_name() const { return m_plugin->format_name(); }
u16 bits_per_sample() const { return pcm_bits_per_sample(m_plugin->pcm_format()); }
RefPtr<Core::File> file() const { return m_plugin->file(); }
private:
static Result<NonnullOwnPtr<LoaderPlugin>, LoaderError> try_create(StringView path);