RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:38:11 +00:00
Code Issues Activity Actions

LibJS: Multiple 'default' clauses in switch statement are a syntax error

Browse source
This commit is contained in:
Linus Groh 2020-10-18 23:12:27 +01:00 • committed by Andreas Kling
parent 57e7b2f8e4
commit 2dbea60fe2
2 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibJS/Parser.cpp
View file

@ -1519,8 +1519,15 @@ NonnullRefPtr<SwitchStatement> Parser::parse_switch_statement()
NonnullRefPtrVector<SwitchCase> cases;
while (match(TokenType::Case) || match(TokenType::Default))
auto has_default = false;
while (match(TokenType::Case) || match(TokenType::Default)) {
if (match(TokenType::Default)) {
if (has_default)
syntax_error("Multiple 'default' clauses in switch statement");
has_default = true;
}
cases.append(parse_switch_case());
}
consume(TokenType::CurlyClose);

8
Libraries/LibJS/Tests/switch-basic.js
View file

@ -68,3 +68,11 @@ describe("basic switch tests", () => {
expect(i).toBe(5);
});
});
describe("errors", () => {
test("syntax errors", () => {
expect("switch () {}").not.toEval();
expect("switch (foo) { bar }").not.toEval();
expect("switch (foo) { default: default: }").not.toEval();
});
});