RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 01:37:36 +00:00
Code Issues Activity Actions

HexEditor: Handle some errors inside the editor

Browse source 
Specifically, the ones HexEditor::did_complete_action possibly raised in
case creating an undo stack entry or pushing it onto the undo stack
fails. In this case, an error popup is displayed and the modifications
are undone.

This removes 2 FIXMEs inside the code :^)
This commit is contained in:
Arda Cinar 2022-12-07 21:32:07 +03:00 • committed by Andrew Kaster
parent d3ce9cf8f6
commit 2dd7fa2d44
3 changed files with 60 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Applications/HexEditor/HexEditor.h
View file

@ -36,7 +36,7 @@ public:
size_t buffer_size() const { return m_document->size(); }
ErrorOr<void> open_new_file(size_t size);
void open_file(NonnullRefPtr<Core::File> file);
void fill_selection(u8 fill_byte);
ErrorOr<void> fill_selection(u8 fill_byte);
Optional<u8> get_byte(size_t position);
bool save_as(NonnullRefPtr<Core::File>);
bool save();
@ -101,14 +101,14 @@ private:
size_t cell_width() const { return character_width() * 3; }
size_t offset_margin_width() const { return 80; }
void hex_mode_keydown_event(GUI::KeyEvent&);
void text_mode_keydown_event(GUI::KeyEvent&);
ErrorOr<void> hex_mode_keydown_event(GUI::KeyEvent&);
ErrorOr<void> text_mode_keydown_event(GUI::KeyEvent&);
void set_content_length(size_t); // I might make this public if I add fetching data on demand.
void update_status();
void did_change();
void did_complete_action(size_t position, u8 old_value, u8 new_value);
void did_complete_action(size_t position, ByteBuffer&& old_values, ByteBuffer&& new_values);
ErrorOr<void> did_complete_action(size_t position, u8 old_value, u8 new_value);
ErrorOr<void> did_complete_action(size_t position, ByteBuffer&& old_values, ByteBuffer&& new_values);
void reset_cursor_blink_state();
};