RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 20:15:00 +00:00
Code Issues Activity Actions

LibWeb: Allow setting HTMLTableElement.tFoot to null value

Browse source 
This annihilates 2 FIXMEs :^)
This commit is contained in:
Andreas Kling 2022-12-15 20:08:13 +01:00
parent 346737701d
commit 2ded895107
1 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Userland/Libraries/LibWeb/HTML/HTMLTableElement.cpp
View file

@ -189,8 +189,11 @@ void HTMLTableElement::delete_t_head()
} }
} }
// https://html.spec.whatwg.org/multipage/tables.html#dom-table-tfoot
JS::GCPtr<HTMLTableSectionElement> HTMLTableElement::t_foot() JS::GCPtr<HTMLTableSectionElement> HTMLTableElement::t_foot()
{ {
// The tFoot IDL attribute must return, on getting, the first tfoot element child of the table element,
// if any, or null otherwise.
for (auto* child = first_child(); child; child = child->next_sibling()) { for (auto* child = first_child(); child; child = child->next_sibling()) {
if (is<HTMLTableSectionElement>(*child)) { if (is<HTMLTableSectionElement>(*child)) {
auto table_section_element = &verify_cast<HTMLTableSectionElement>(*child); auto table_section_element = &verify_cast<HTMLTableSectionElement>(*child);
@ -202,20 +205,21 @@ JS::GCPtr<HTMLTableSectionElement> HTMLTableElement::t_foot()
return nullptr; return nullptr;
} }
// https://html.spec.whatwg.org/multipage/tables.html#dom-table-tfoot
WebIDL::ExceptionOr<void> HTMLTableElement::set_t_foot(HTMLTableSectionElement* tfoot) WebIDL::ExceptionOr<void> HTMLTableElement::set_t_foot(HTMLTableSectionElement* tfoot)
{ {
// FIXME: This is not always the case, but this function is currently written in a way that assumes non-null. // If the new value is neither null nor a tfoot element, then a "HierarchyRequestError" DOMException must be thrown instead.
VERIFY(tfoot); if (tfoot && tfoot->local_name() != TagNames::tfoot)
if (tfoot->local_name() != TagNames::tfoot)
return WebIDL::HierarchyRequestError::create(realm(), "Element is not tfoot"); return WebIDL::HierarchyRequestError::create(realm(), "Element is not tfoot");
// FIXME: The spec requires deleting the current tfoot if tfoot is null // On setting, if the new value is null or a tfoot element, the first tfoot element child of the table element,
// Currently the wrapper generator doesn't send us a nullable value // if any, must be removed,
delete_t_foot(); delete_t_foot();
// We insert the new tfoot at the end of the table // and the new value, if not null, must be inserted at the end of the table.
TRY(append_child(*tfoot)); if (tfoot) {
TRY(append_child(*tfoot));
}
return {}; return {};
} }