RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 03:57:43 +00:00
Code Issues Activity Actions

LibWeb: Handle reference cycles in SVG gradient linking

Browse source 
Since SVG gradients can reference each other, we have to keep track of
visited gradients when traversing the link chain, or we will recurse
infinitely when there's a reference cycle.
This commit is contained in:
Andreas Kling 2024-03-10 12:18:09 +01:00
parent 1b8d8c7bbc
commit 2e0297d703
8 changed files with 155 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

40
Userland/Libraries/LibWeb/SVG/SVGLinearGradientElement.cpp
View file

@ -48,44 +48,68 @@ void SVGLinearGradientElement::attribute_changed(FlyString const& name, Optional
// https://www.w3.org/TR/SVG11/pservers.html#LinearGradientElementX1Attribute
NumberPercentage SVGLinearGradientElement::start_x() const
{
HashTable<SVGGradientElement const*> seen_gradients;
return start_x_impl(seen_gradients);
}
NumberPercentage SVGLinearGradientElement::start_x_impl(HashTable<SVGGradientElement const*>& seen_gradients) const
{
if (m_x1.has_value())
return *m_x1;
if (auto gradient = linked_linear_gradient())
return gradient->start_x();
if (auto gradient = linked_linear_gradient(seen_gradients))
return gradient->start_x_impl(seen_gradients);
// If the attribute is not specified, the effect is as if a value of '0%' were specified.
return NumberPercentage::create_percentage(0);
}
// https://www.w3.org/TR/SVG11/pservers.html#LinearGradientElementY1Attribute
NumberPercentage SVGLinearGradientElement::start_y() const
{
HashTable<SVGGradientElement const*> seen_gradients;
return start_y_impl(seen_gradients);
}
NumberPercentage SVGLinearGradientElement::start_y_impl(HashTable<SVGGradientElement const*>& seen_gradients) const
{
if (m_y1.has_value())
return *m_y1;
if (auto gradient = linked_linear_gradient())
return gradient->start_x();
if (auto gradient = linked_linear_gradient(seen_gradients))
return gradient->start_y_impl(seen_gradients);
// If the attribute is not specified, the effect is as if a value of '0%' were specified.
return NumberPercentage::create_percentage(0);
}
// https://www.w3.org/TR/SVG11/pservers.html#LinearGradientElementX2Attribute
NumberPercentage SVGLinearGradientElement::end_x() const
{
HashTable<SVGGradientElement const*> seen_gradients;
return end_x_impl(seen_gradients);
}
NumberPercentage SVGLinearGradientElement::end_x_impl(HashTable<SVGGradientElement const*>& seen_gradients) const
{
if (m_x2.has_value())
return *m_x2;
if (auto gradient = linked_linear_gradient())
return gradient->start_x();
if (auto gradient = linked_linear_gradient(seen_gradients))
return gradient->end_x_impl(seen_gradients);
// If the attribute is not specified, the effect is as if a value of '100%' were specified.
return NumberPercentage::create_percentage(100);
}
// https://www.w3.org/TR/SVG11/pservers.html#LinearGradientElementY2Attribute
NumberPercentage SVGLinearGradientElement::end_y() const
{
HashTable<SVGGradientElement const*> seen_gradients;
return end_y_impl(seen_gradients);
}
NumberPercentage SVGLinearGradientElement::end_y_impl(HashTable<SVGGradientElement const*>& seen_gradients) const
{
if (m_y2.has_value())
return *m_y2;
if (auto gradient = linked_linear_gradient())
return gradient->start_x();
if (auto gradient = linked_linear_gradient(seen_gradients))
return gradient->end_y_impl(seen_gradients);
// If the attribute is not specified, the effect is as if a value of '0%' were specified.
return NumberPercentage::create_percentage(0);
}