RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:57:44 +00:00
Code Issues Activity Actions

LibWeb: Handle reference cycles in SVG gradient linking

Browse source 
Since SVG gradients can reference each other, we have to keep track of
visited gradients when traversing the link chain, or we will recurse
infinitely when there's a reference cycle.
This commit is contained in:
Andreas Kling 2024-03-10 12:18:09 +01:00
parent 1b8d8c7bbc
commit 2e0297d703
8 changed files with 155 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/SVG/SVGLinearGradientElement.h
View file

@ -34,9 +34,9 @@ protected:
virtual void initialize(JS::Realm&) override;
private:
JS::GCPtr<SVGLinearGradientElement const> linked_linear_gradient() const
JS::GCPtr<SVGLinearGradientElement const> linked_linear_gradient(HashTable<SVGGradientElement const*>& seen_gradients) const
{
if (auto gradient = linked_gradient(); gradient && is<SVGLinearGradientElement>(*gradient))
if (auto gradient = linked_gradient(seen_gradients); gradient && is<SVGLinearGradientElement>(*gradient))
return &verify_cast<SVGLinearGradientElement>(*gradient);
return {};
}
@ -46,6 +46,11 @@ private:
NumberPercentage end_x() const;
NumberPercentage end_y() const;
NumberPercentage start_x_impl(HashTable<SVGGradientElement const*>& seen_gradients) const;
NumberPercentage start_y_impl(HashTable<SVGGradientElement const*>& seen_gradients) const;
NumberPercentage end_x_impl(HashTable<SVGGradientElement const*>& seen_gradients) const;
NumberPercentage end_y_impl(HashTable<SVGGradientElement const*>& seen_gradients) const;
Optional<NumberPercentage> m_x1;
Optional<NumberPercentage> m_y1;
Optional<NumberPercentage> m_x2;