From 2e1a01a499d0fd0294922c4d77b19745ed0a6960 Mon Sep 17 00:00:00 2001 From: sinmineryt <50749166+sinmineryt@users.noreply.github.com> Date: Sun, 13 Jun 2021 13:38:07 +0200 Subject: [PATCH] TextEditor: Don't allow opening directories Previously it was possible to open a directory in the TextEditor application. Like device files, these are now rejected with an error message. --- Userland/Applications/TextEditor/MainWidget.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Userland/Applications/TextEditor/MainWidget.cpp b/Userland/Applications/TextEditor/MainWidget.cpp index a62d824160..83eef1b554 100644 --- a/Userland/Applications/TextEditor/MainWidget.cpp +++ b/Userland/Applications/TextEditor/MainWidget.cpp @@ -653,6 +653,11 @@ bool MainWidget::open_file(const String& path) return false; } + if (file->is_directory()) { + GUI::MessageBox::show(window(), String::formatted("Opening \"{}\" failed: Can't open directories", path), "Error", GUI::MessageBox::Type::Error); + return false; + } + m_editor->set_text(file->read_all()); set_path(LexicalPath(path));