From 2e38df7bd1d933a76100888926ff6f5d4cb0ca3a Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 9 Dec 2019 15:51:10 +0100 Subject: [PATCH] Kernel: Assert that device major/minor hasn't already been registered It would be a bug to have multiple devices with the same major/minor so let's have an assertion for that. --- Kernel/Devices/Device.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Kernel/Devices/Device.cpp b/Kernel/Devices/Device.cpp index 86458f77ae..94f02331b7 100644 --- a/Kernel/Devices/Device.cpp +++ b/Kernel/Devices/Device.cpp @@ -29,7 +29,9 @@ Device::Device(unsigned major, unsigned minor) : m_major(major) , m_minor(minor) { - all_devices().set(encoded_device(m_major, m_minor), this); + u32 device_id = encoded_device(major, minor); + ASSERT(!all_devices().contains(device_id)); + all_devices().set(device_id, this); } Device::~Device()