RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:07:44 +00:00
Code Issues Activity Actions

Everywhere: Fix format-vulnerabilities

Browse source 
Command used:
grep -Pirn '(out|warn)ln\((?!["\)]|format,|stderr,|stdout,|output, ")' \
     AK Kernel/ Tests/ Userland/
(Plus some manual reviewing.)

Let's pick ArgsParser as an example:
    outln(file, m_general_help);
This will fail at runtime if the general help happens to contain braces.

Even if this transformation turns out to be unnecessary in a place or
two, this way the code is "more obviously" correct.
This commit is contained in:
Ben Wiederhake 2021-09-09 17:06:15 +02:00 • committed by Linus Groh
parent 7dfecbee44
commit 2e4ec891da
4 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibSQL/TestSqlStatementExecution.cpp
View file

@ -24,7 +24,7 @@ RefPtr<SQL::SQLResult> execute(NonnullRefPtr<SQL::Database> database, String con
auto statement = parser.next_statement();
EXPECT(!parser.has_errors());
if (parser.has_errors()) {
outln(parser.errors()[0].to_string());
outln("{}", parser.errors()[0].to_string());
}
SQL::AST::ExecutionContext context { database };
auto result = statement->execute(context);