RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:17:45 +00:00
Code Issues Activity Actions

AK+WindowServer: Remove did_construct() framework used only once

Browse source 
There is also make_ref_counted(), which does not call did_construct(),
so the method was not guaranteed to be run. Since there is only a single
user, and `WindowServer::Window` is a final class anyway (so there is no
need to separate the constructor and post-constructor phases), let's get
rid of this concept.

(The following commits reduce the opportunities to call
make_ref_counted, but still.)
This commit is contained in:
Ben Wiederhake 2021-10-31 23:21:51 +01:00 • committed by Andreas Kling
parent 68c8d23e39
commit 2e6bb987a3
3 changed files with 1 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Services/WindowServer/Window.h
View file

@ -362,11 +362,6 @@ public:
const Vector<Screen*, default_screen_count>& screens() const { return m_screens; }
Vector<Screen*, default_screen_count>& screens() { return m_screens; }
void did_construct()
{
frame().window_was_constructed({});
}
void set_moving_to_another_stack(bool value) { m_moving_to_another_stack = value; }
bool is_moving_to_another_stack() const { return m_moving_to_another_stack; }