From 2e98c173475abbf5589a7162f3af4d247bf8336c Mon Sep 17 00:00:00 2001
From: Andreas Kling <kling@serenityos.org>
Date: Sat, 26 Nov 2022 20:33:52 +0100
Subject: [PATCH] LibJS: Shrink DeclarativeEnvironment bindings vector to fit

After setting up all the bindings in function_declaration_instantiation,
we now ask DeclarativeEnvironment to do a shrink_to_fit() on its vector
of bindings.

This ends up saving 5.6 MiB on twitter.com/awesomekling :^)
---
 Userland/Libraries/LibJS/Runtime/DeclarativeEnvironment.cpp  | 5 +++++
 Userland/Libraries/LibJS/Runtime/DeclarativeEnvironment.h    | 2 ++
 .../Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp     | 5 +++++
 3 files changed, 12 insertions(+)

diff --git a/Userland/Libraries/LibJS/Runtime/DeclarativeEnvironment.cpp b/Userland/Libraries/LibJS/Runtime/DeclarativeEnvironment.cpp
index d910d0a61c..0449887535 100644
--- a/Userland/Libraries/LibJS/Runtime/DeclarativeEnvironment.cpp
+++ b/Userland/Libraries/LibJS/Runtime/DeclarativeEnvironment.cpp
@@ -231,4 +231,9 @@ void DeclarativeEnvironment::initialize_or_set_mutable_binding(Badge<ScopeNode>,
     MUST(initialize_or_set_mutable_binding(vm, name, value));
 }
 
+void DeclarativeEnvironment::shrink_to_fit()
+{
+    m_bindings.shrink_to_fit();
+}
+
 }
diff --git a/Userland/Libraries/LibJS/Runtime/DeclarativeEnvironment.h b/Userland/Libraries/LibJS/Runtime/DeclarativeEnvironment.h
index ceea57c9d7..18a905d531 100644
--- a/Userland/Libraries/LibJS/Runtime/DeclarativeEnvironment.h
+++ b/Userland/Libraries/LibJS/Runtime/DeclarativeEnvironment.h
@@ -57,6 +57,8 @@ public:
     ThrowCompletionOr<void> set_mutable_binding_direct(VM&, size_t index, Value, bool strict);
     ThrowCompletionOr<Value> get_binding_value_direct(VM&, size_t index, bool strict);
 
+    void shrink_to_fit();
+
 private:
     ThrowCompletionOr<void> initialize_binding_direct(VM&, Binding&, Value);
     ThrowCompletionOr<Value> get_binding_value_direct(VM&, Binding&, bool strict);
diff --git a/Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp b/Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp
index f0ba8470ca..9d65077b9c 100644
--- a/Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp
+++ b/Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp
@@ -577,6 +577,11 @@ ThrowCompletionOr<void> ECMAScriptFunctionObject::function_declaration_instantia
         MUST(var_environment->set_mutable_binding(vm, declaration.name(), function, false));
     }
 
+    if (is<DeclarativeEnvironment>(*lex_environment))
+        static_cast<DeclarativeEnvironment*>(lex_environment)->shrink_to_fit();
+    if (is<DeclarativeEnvironment>(*var_environment))
+        static_cast<DeclarativeEnvironment*>(var_environment)->shrink_to_fit();
+
     return {};
 }