RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 20:17:41 +00:00
Code Issues Activity Actions

LibCore: Use AK_MAKE_DEFAULT_MOVABLE to avoid mistakes in default impls

Browse source
This commit is contained in:
Ben Wiederhake 2023-06-16 16:15:15 +02:00 • committed by Sam Atkins
parent 2b2e0a4c5a
commit 2ebd79bc76
3 changed files with 3 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibCore/SecretString.h
View file

@ -14,6 +14,7 @@ namespace Core {
class SecretString { class SecretString {
AK_MAKE_NONCOPYABLE(SecretString); AK_MAKE_NONCOPYABLE(SecretString);
AK_MAKE_DEFAULT_MOVABLE(SecretString);
public: public:
[[nodiscard]] static ErrorOr<SecretString> take_ownership(char*&, size_t); [[nodiscard]] static ErrorOr<SecretString> take_ownership(char*&, size_t);
@ -26,8 +27,6 @@ public:
SecretString() = default; SecretString() = default;
~SecretString(); ~SecretString();
SecretString(SecretString&&) = default;
SecretString& operator=(SecretString&&) = default;
private: private:
explicit SecretString(ByteBuffer&&); explicit SecretString(ByteBuffer&&);

2
Userland/Libraries/LibCore/System.h
View file

@ -237,9 +237,9 @@ ErrorOr<int> poll(Span<struct pollfd>, int timeout);
class AddressInfoVector { class AddressInfoVector {
AK_MAKE_NONCOPYABLE(AddressInfoVector); AK_MAKE_NONCOPYABLE(AddressInfoVector);
AK_MAKE_DEFAULT_MOVABLE(AddressInfoVector);
public: public:
AddressInfoVector(AddressInfoVector&&) = default;
~AddressInfoVector() = default; ~AddressInfoVector() = default;
ReadonlySpan<struct addrinfo> addresses() const { return m_addresses; } ReadonlySpan<struct addrinfo> addresses() const { return m_addresses; }

7
Userland/Libraries/LibCore/ThreadEventQueue.cpp
View file

@ -18,6 +18,7 @@ namespace Core {
struct ThreadEventQueue::Private { struct ThreadEventQueue::Private {
struct QueuedEvent { struct QueuedEvent {
AK_MAKE_NONCOPYABLE(QueuedEvent); AK_MAKE_NONCOPYABLE(QueuedEvent);
AK_MAKE_DEFAULT_MOVABLE(QueuedEvent);
public: public:
QueuedEvent(Object& receiver, NonnullOwnPtr<Event> event) QueuedEvent(Object& receiver, NonnullOwnPtr<Event> event)
@ -26,12 +27,6 @@ struct ThreadEventQueue::Private {
{ {
} }
QueuedEvent(QueuedEvent&& other)
: receiver(other.receiver)
, event(move(other.event))
{
}
~QueuedEvent() = default; ~QueuedEvent() = default;
WeakPtr<Object> receiver; WeakPtr<Object> receiver;